Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp686530pxb; Wed, 27 Jan 2021 19:15:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJzyp5LzEMSdBhdObjetrI6JJ681CI/Fa8zrYnIFRtUfe8XGDn2k1WlkaJe8aTlaaqY2F2rZ X-Received: by 2002:a17:906:4e47:: with SMTP id g7mr7993545ejw.480.1611803709943; Wed, 27 Jan 2021 19:15:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611803709; cv=none; d=google.com; s=arc-20160816; b=TQkHaUqxJysSrCLX69LPBhw78vlBQWaJXmxSoYSEPdVlfRnamt4l5hvX9dGQrCY+GP uT2Pz49AEqiFGPUyxiBKxFQzd3Wzg0m0lW1kAxmagFulxG1x2RVkYSAdyZJKRdy1JTOq n20DUeT9qyDGP0ZK/JtVRb0cWr1lyn+SfLl1VxY+PJgmbnKR8yE3qmtxTRYmsU0WwW3z 5vmVUDOo3ll4WiNSscNFrqyJ9JV9HsoIsPcUuqTQL9kBj2ghCtpO4jnWQzrdenczb385 Dxjt7LmhSR/KYD1HuB8tTxevwQ0ccswPhtVRweHn8GtNBg4+ykvOOWXL/71RO55n5ET5 SVdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=5V1yHfKC7OiSQv/x7DVZg/ULjSjNyPWH9oXz1xWf9YM=; b=Ka9lTcphhHInW5FtU6oLCs2ZLMbDqaD3A1NYQvZuawQxjEVGKW0y/aW56pbFGk/vfk eo41r+zcs5HMH8Xtd+ep9rO/iq+bwEogJp2l0Oupfwfwpx9cu06GzJbcxjd5q3ZDv0jy Jh/1VTwCzqKmroXbwRy7IOJ51qpTGr0G+sTp2AbQrC/pIMC/MWM+g2KttTOePCgea2bj Ey+mudsh+6e/9sZRQ3aTYKEHnBRvS3g9J+WWO6Aa7hOLEtwzhBqtS18TFMmVD+PCmSn7 4lPxs0ArSy5POumGoAA4dpYiV3dgJuznW97BNexQsV8i/2y2V+uKoLv7wGH/vjKtHg1S HGvQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u7si2034388edx.172.2021.01.27.19.14.46; Wed, 27 Jan 2021 19:15:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229545AbhA1DLo (ORCPT + 99 others); Wed, 27 Jan 2021 22:11:44 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:41725 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229739AbhA1DLh (ORCPT ); Wed, 27 Jan 2021 22:11:37 -0500 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 10S3AlsO022175 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Jan 2021 22:10:47 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 0C99815C344F; Wed, 27 Jan 2021 22:10:47 -0500 (EST) Date: Wed, 27 Jan 2021 22:10:47 -0500 From: "Theodore Ts'o" To: Arnaud Ferraris Cc: linux-ext4@vger.kernel.org, drosen@google.com, krisman@collabora.com, ebiggers@kernel.org Subject: Re: [PATCH v3 07/12] e2fsck: Support casefold directories when rehashing Message-ID: References: <20201217173544.52953-1-arnaud.ferraris@collabora.com> <20201217173544.52953-8-arnaud.ferraris@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201217173544.52953-8-arnaud.ferraris@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Dec 17, 2020 at 06:35:39PM +0100, Arnaud Ferraris wrote: > From: Gabriel Krisman Bertazi > > When rehashing a +F directory, the casefold comparison needs to be > performed, in order to identify duplicated filenames. Like the -F > version, This is done in two steps, first adapt the qsort comparison to > consider casefolded directories, and then iterate over the sorted list > fixing dups. > > Signed-off-by: Gabriel Krisman Bertazi > Signed-off-by: Arnaud Ferraris Thanks, applied. - Ted