Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210115181819.34732-1-ebiggers@kernel.org> <20210115181819.34732-3-ebiggers@kernel.org>
In-Reply-To: <20210115181819.34732-3-ebiggers@kernel.org>
From:   Amy Parker <enbyamy@gmail.com>
Date:   Wed, 27 Jan 2021 19:24:05 -0800
Message-ID: <CAE1WUT7v4PTu2hEgDSpj+Y3f_Hn0XzOH3kO1-eYkOUgNun_9DA@mail.gmail.com>
Subject: Re: [PATCH 2/6] fs-verity: don't pass whole descriptor to fsverity_verify_signature()
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        Ext4 Developers List <linux-ext4@vger.kernel.org>,
        linux-f2fs-devel@lists.sourceforge.net, linux-api@vger.kernel.org,
        "Theodore Ts'o" <tytso@mit.edu>, Jaegeuk Kim <jaegeuk@kernel.org>,
        Victor Hsieh <victorhsieh@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jan 15, 2021 at 10:22 AM Eric Biggers <ebiggers@kernel.org> wrote:
>
> From: Eric Biggers <ebiggers@google.com>
>
> Now that fsverity_get_descriptor() validates the sig_size field,
> fsverity_verify_signature() doesn't need to do it.
>
> Just change the prototype of fsverity_verify_signature() to take the
> signature directly rather than take a fsverity_descriptor.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Reviewed-by: Amy Parker <enbyamy@gmail.com>