Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 27 Jan 2021 23:08:58 -0500
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Arnaud Ferraris <arnaud.ferraris@collabora.com>
Cc:     linux-ext4@vger.kernel.org, drosen@google.com,
        krisman@collabora.com, ebiggers@kernel.org
Subject: Re: [PATCH v3 12/12] tests: f_bad_fname: Test fixes of invalid
 filenames and duplicates
Message-ID: <YBI42sG2VcE25h4h@mit.edu>
References: <20201217173544.52953-1-arnaud.ferraris@collabora.com>
 <20201217173544.52953-13-arnaud.ferraris@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201217173544.52953-13-arnaud.ferraris@collabora.com>
Precedence: bulk

On Thu, Dec 17, 2020 at 06:35:44PM +0100, Arnaud Ferraris wrote:
> From: Gabriel Krisman Bertazi <krisman@collabora.com>
> 
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
> Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>

It looks like you didn't regenerate the expect.1 file after changing
the problem description.

% cat f_bad_fname.failed 
--- /usr/projects/e2fsprogs/e2fsprogs/tests/f_bad_fname/expect.1	2021-01-28 03:20:36.813595045 +0000
+++ f_bad_fname.1.log	2021-01-28 03:25:49.940137813 +0000
@@ -1,9 +1,9 @@
 Pass 1: Checking inodes, blocks, and sizes
 Pass 2: Checking directory structure
-Entry 'AM-^?' in /ci_dir (12) has illegal characters in its name.
+Entry 'AM-^?' in /ci_dir (12) has illegal UTF-8 characters in its name.
 Fix? yes
 
-Entry 'AM-~' in /ci_dir (12) has illegal characters in its name.
+Entry 'AM-~' in /ci_dir (12) has illegal UTF-8 characters in its name.
 Fix? yes
 
 Duplicate entry 'A.' found.

I'll fix this up in my tree.

     	           	      	       - Ted