Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp14130pxb; Tue, 2 Feb 2021 21:06:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJyFyykz+VY77Cm2flhxNtudYLPBh04LnwyH/u4HzPrB5ByBI6ZNlg9X+4YfDAdzZkpQXGhU X-Received: by 2002:a50:f19a:: with SMTP id x26mr1324104edl.354.1612328813678; Tue, 02 Feb 2021 21:06:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612328813; cv=none; d=google.com; s=arc-20160816; b=FEBeUjiZDxmwWhWuYY8JqU5UIELRaai2Z74mGUWpB+nHx+xo6xLNGp5fh5XWLYQDvk rTJRo+qZOH1n0DEURFvLgaKUmRbb3VEbP8JlC5YbkAc67p+y/DdaNsh7s1JTYLGM/kya /lHjCxS4T76uIKob4paUY8+ZY2hnf2C66WKiaRfmYzCu+pwabFRpAGx08t+a8uwSdGwn kG/KT3PdQp/yFGgD1TLeoDTzr5kuMPsp0mO38X16h6647v/1H9tkbCgwuuaAwlGbxgDO C/PY1kH296JxZ1JEwT3xZsY35v6UFzgr7G/SYgLm550tpnOK5fs+R9KCJj52C6k/4UWF EgPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=JXI2tLsw7b/lblLULxG67mItJ7kG8zjS8bS9a9yLqz8=; b=mw7T6eThYWxJ23x8sBeA03/ssdNG3eWTz7WDYidzuNmnazGrqc/OHAtwctIIqCraov mc466ats4aziuI06k6cdM4yZWJbeWKuxx2IwynSCzCC12SDw0NGAkFvb3AZfb7pkxLYc HIlrpzoUxmDvW0iOA9TF/KH2yx8qkhCymdh5Ldqh43Pacgt6IBKXA3blFPFXC7DsJkxG aaT9+RVN4ZyNcXfGH+nEg1fu01r2LNx5RCykKryJC/8fH00g9c9JYZIBs495yLnkK5kK 1HoWaLwidO9xr9CZtyoWVmnlK88YrjILvh2/1CI77i2dBNYSxyRnJFWmX/TLYb0ZRi2v h0lA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g23si556435edh.11.2021.02.02.21.06.21; Tue, 02 Feb 2021 21:06:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229496AbhBCFGU (ORCPT + 99 others); Wed, 3 Feb 2021 00:06:20 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:42540 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229487AbhBCFGT (ORCPT ); Wed, 3 Feb 2021 00:06:19 -0500 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 11355O9M011510 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 3 Feb 2021 00:05:24 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 0188915C39E2; Wed, 3 Feb 2021 00:05:23 -0500 (EST) Date: Wed, 3 Feb 2021 00:05:23 -0500 From: "Theodore Ts'o" To: Daejun Park Cc: harshad shirwadkar , "adilger.kernel@dilger.ca" , "linux-kernel@vger.kernel.org" , "linux-ext4@vger.kernel.org" Subject: Re: [PATCH v2] ext4: Change list_for_each* to list_for_each_entry* Message-ID: References: <20210111013726epcms2p4579ae56040d7043db785bf0d0a785dc7@epcms2p4> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210111013726epcms2p4579ae56040d7043db785bf0d0a785dc7@epcms2p4> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Jan 11, 2021 at 10:37:26AM +0900, Daejun Park wrote: > In the fast_commit.c, list_for_each* + list_entry can be changed to > list_for_each_entry*. It reduces number of variables and lines. > > Signed-off-by: Daejun Park Thanks, applied. - Ted