Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1591084pxb; Thu, 4 Feb 2021 17:52:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJxGG8hSAl7r0WjJAHx6mCkjKAeVDxNfcyfdLCpdVpNwjpqKPWJi1g9a9Kw5mv+/CR9PdccN X-Received: by 2002:a05:6402:702:: with SMTP id w2mr1412965edx.78.1612489951282; Thu, 04 Feb 2021 17:52:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612489951; cv=none; d=google.com; s=arc-20160816; b=Vgq2B5EbDPI2u4THI0wBLea/6bxiy2fFMTZRIl70zoCKjuwQtoEbSRdHFJA0YJnmdK 2VuJQcqBP5E8byyC8P3ZDr9UTRBodQEOmsqYtSS3HbRfQndgRM37CR2F5uzUy0iOOQNg h163sb4iKb4FMtV0YAV+E/KTCXOGych+IZwRrf+KCYSFUjgrYatXtnnvwXzG1bYNiO0I g8BM9/4zpevSsbn7p0Gzgx0as1KhOQRw3IYGV++bVLbeLShf8BherMXz1hAghduXBJ4x DdgFWiExTSBLEvfiNHEM02L3Cres5gJ7EHLh1hjH4WQQPA20+5FXpwX4xCOQIXmgxz+U aUvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=6PnlMDYeUbYvPqGBr55A/KTQ5JKZla7+L5wiTNs3I1U=; b=TDs6WEi0kSGaT4fgKS7dl/x/b90mUTLDzjN4uBEIbkOkm5WM59R8oRUyZn+nRfY2AN qRy/X5bjZ1R/amCI743yzPP5V4TVYSLKRIOs0rbwb8JPF7GLokrp9YHFo3arlzcT1nbp 7QEGubJmPeG5GEAPSjurBVQ8pSLnWyqEJ7OK9I+H9US8TVP/tE8wSl1itNy6H7h6aOd2 PL+7iyZxnE358RZUIS5cvwEpuW8+YmhxbDl4XO6NmXV8yH/XrvOFzhQYJKXsLOGwdS5b 0PdLd5M/7RrhrfTxWUMSr0KWsdI/90qJXf8GtpdVR6zLHSQ+ZZZwc+L4zE321rt1nAX7 acwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uCX0kuk0; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q7si4358688edt.86.2021.02.04.17.52.03; Thu, 04 Feb 2021 17:52:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uCX0kuk0; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230153AbhBDXgz (ORCPT + 99 others); Thu, 4 Feb 2021 18:36:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230039AbhBDXgy (ORCPT ); Thu, 4 Feb 2021 18:36:54 -0500 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54167C0613D6 for ; Thu, 4 Feb 2021 15:36:14 -0800 (PST) Received: by mail-pg1-x52f.google.com with SMTP id s23so3213874pgh.11 for ; Thu, 04 Feb 2021 15:36:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6PnlMDYeUbYvPqGBr55A/KTQ5JKZla7+L5wiTNs3I1U=; b=uCX0kuk0hJX8WacPk8GcknlnKKqTGJ1mW2PCV5UcynRNvUFrh3flM6UrQHGY602F0W 6ti/EKhJ2Vzpt2wi+QEMbaWqEGO3uKk4o+QiDDuzZGHosdDk//89EsV8Piyu4Gfb2Ghl vqXtqvs7KjGM0Etlhytsiu6c9Bt6htlHpwfYtPqEmrX5uYDOjSTnEMohzN2XW+fXwyoJ xNkd8G6ddJLox+wOqi+VhGPddw6JDb775Pk1XS9CRCZAa+4tlhYSELcbfAYZRBLnhI2Z VChR01c7zCT5aCRfoTz6I1LddbKNIub0muoutiOU2eZaCKS53PSVHzCdutberONTQUGw gybw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6PnlMDYeUbYvPqGBr55A/KTQ5JKZla7+L5wiTNs3I1U=; b=KbBcmjzcysaDg0BAOAkAOOl2NJ4j9n6Gy747c++3IRey4vSh+an7zMSzEc1tymiL3D iP5I+8dwGB+HJnwwWx0vs6yZ9Wlvvi51bVho3yK0Jn2wmeozR1emXr19gWZjMNOVg6R/ I6hoOl+Lx0jwrXD20QziGdAtCd5M32ylBQV4SHWSbRgX8hjOeOJfqO4TZdvb8Chje3tz 45ARiuOQPwJtprrEnUCYF6l7tx/oZ8Q88FI1vZCdkxfAn42Yt8pwjOpDyHI+cSxWKZnV qASQek7pJs80fKNxdyoKHJ2N35WwssISYEjlshOvHBYBwcYiYN5oH/2yvQTWKRz76Y8x 5EEw== X-Gm-Message-State: AOAM533tsJqMWGd8A4/NsaZYcgX9MSYRkp2FCooCpcCzQaBzY9d6/uXa oIqLIiq3zGC0yZ7xPi3vIOvtuIVJ0Ac= X-Received: by 2002:a63:5642:: with SMTP id g2mr1364791pgm.434.1612481773374; Thu, 04 Feb 2021 15:36:13 -0800 (PST) Received: from harshads-520.kir.corp.google.com ([2620:15c:17:10:5142:d9c7:4222:def5]) by smtp.googlemail.com with ESMTPSA id mv14sm10236149pjb.0.2021.02.04.15.36.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 15:36:12 -0800 (PST) From: Harshad Shirwadkar X-Google-Original-From: Harshad Shirwadkar To: linux-ext4@vger.kernel.org Cc: tytso@mit.edu, Harshad Shirwadkar Subject: [PATCH 1/3] ext2fs: initialize handle to NULL in ext2fs_count_blks Date: Thu, 4 Feb 2021 15:35:59 -0800 Message-Id: <20210204233601.2369470-1-harshads@google.com> X-Mailer: git-send-email 2.30.0.365.g02bc693789-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Harshad Shirwadkar Initialize the handle to NULL to ensure that in error cases, ext2fs_free_mem can be called on it. Signed-off-by: Harshad Shirwadkar --- lib/ext2fs/extent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ext2fs/extent.c b/lib/ext2fs/extent.c index bde6b0f3..1a87e68b 100644 --- a/lib/ext2fs/extent.c +++ b/lib/ext2fs/extent.c @@ -1809,7 +1809,7 @@ errcode_t ext2fs_decode_extent(struct ext2fs_extent *to, void *addr, int len) errcode_t ext2fs_count_blocks(ext2_filsys fs, ext2_ino_t ino, struct ext2_inode *inode, blk64_t *ret_count) { - ext2_extent_handle_t handle; + ext2_extent_handle_t handle = NULL; struct ext2fs_extent extent; errcode_t errcode; int i; -- 2.30.0.365.g02bc693789-goog