Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1592047pxb; Thu, 4 Feb 2021 17:54:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJxkiSSHmjEHWmrcvZV6SYRaAzeqrReGI0ERP4bQ8NkSgcySzYlZqqv8+0IXYEXbz7Op8KgY X-Received: by 2002:a17:906:7cb:: with SMTP id m11mr1900773ejc.332.1612490080206; Thu, 04 Feb 2021 17:54:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612490080; cv=none; d=google.com; s=arc-20160816; b=bHapIgCq/KAlw8rNYUwBYTpCTs64/oXWX4fObAFHkqW4DS0equW8SO7a7vO7pYprt4 +bfHnRvBU+hkCqcGm8KFH1yofWd0f/J6UfVwfN4felbNUNiEGnoGEkQ6sy60t65zkEQh 6qgrCaOW0XMgJxYn6SBqYDZfkcVW4GOT3SQvvjit/z8B6Yv1QKwfpN/FAgBXRHeEXDMc 5kKfcGGMCKxx5z8exuBexV7bxm4hkx1pZ/DJAX0n3GLTNZAAuJVTpwNe/cqo7hFIVRi+ f79IAlIPpGqMfHMvdoRRg68nUDLPXsbh7JoZONvItWxhBm4MFdfjjtuLBP/7AxqiRaaN DZlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=h/cCceaH1n7LgzmHcAPZwFCH3eC5URKt6b5rYiHgVWo=; b=WvYE+BJccLHbD7OwViDL7n1kjErBSGVdzxSYmJAqYpNaSjt7FcmTEx/uDo0l41QBuF sZZ8q5uBS8H+aJP1vPXmwnXoWO4e21IbKs8189WlQli31MQHoaKabKNfDulvBktxPeZY aBtnq/bBM+c/W0jIqgLY5Rg2PZ6zdpiDSqIklPwN2K0JqOJFMkQTVz27QA0Q4QFfMKYs GxU4MH2LZcdBAo+X1vvVLr7WSd9R4GvbYQqNZpPfRcukhX2cRhSQR48uNls1YuKj0gad szhIWDZMvBVHpqjrI+Wc5n/t/6BqRJnMNwZzbCKZsflxnDVg77H66PhInrQj2LFp2qSj 8+aw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vC75VFqS; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q7si4358688edt.86.2021.02.04.17.54.15; Thu, 04 Feb 2021 17:54:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vC75VFqS; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230310AbhBDXg4 (ORCPT + 99 others); Thu, 4 Feb 2021 18:36:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230039AbhBDXgz (ORCPT ); Thu, 4 Feb 2021 18:36:55 -0500 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F6CDC061786 for ; Thu, 4 Feb 2021 15:36:15 -0800 (PST) Received: by mail-pg1-x52d.google.com with SMTP id g15so3219314pgu.9 for ; Thu, 04 Feb 2021 15:36:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=h/cCceaH1n7LgzmHcAPZwFCH3eC5URKt6b5rYiHgVWo=; b=vC75VFqSLPj0tDeCCSzSUCCUXc2mpoZs8NX38ab+ot3ZkoMqfZfr0+2E6bTpuEUUcL kShH9SW2bDvwjZoLz+Eqy9FS0dddEzTc3UFo0NxbfjHlYQuxsHd/JWC4QrsgbO8+7o7Z jhB7fb/ZqaYJenLwbEkYAhDhyxhtM0VgXRHSznjBGguE7paLhXVOGfOFLzLy8Skq/912 70OHDu4d9Noq1QBoGEg0mAw960LtrnRrJZqrCycboRhayH/uE8UQel1F+T/tfpm04xU6 EXqTa/5N9VsrSEbRwV69XNEtH69pCSCzORYs+TJ9FfTGri49SOLofr8Au34dVtjTMOzs aKyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=h/cCceaH1n7LgzmHcAPZwFCH3eC5URKt6b5rYiHgVWo=; b=Zx+GeJyksPqal0tkHRU5stDv06hCdG2QqYwxkHoqFThIXAOEE8diBvLQ8terNLtmk5 wa/T1CAkjmstZ/02jBSbrUfYKkmMP+iXYc+u/33EeSJExEyrF0EsW9jti+wVzDmNY7be znoTjgIzy2I0sKPLhKWf+s+V4d40DbiatobirZGMQiOXecT1yUeERYSnTm2oDQPjwcmj Zy+YHIrVJ5h1ZG21Ae2mtie0nf1asGrQdqNbe3geuZjAuNsz+ezAW8+QmQ+mFMc0EIuJ xNcJHcdsMVnQvRL8r2Y9RWN0IJPIus3t2hos8PhvBeX0mJlXhEp4nRmIqZXwfKcbAFV+ DRoA== X-Gm-Message-State: AOAM531n/YwqsQWz22doMqOeT7YvmS/Ko7Kj1WSm8rvvwzFtbrjtq4Tj QuNTk0RV+9ji+zpf0hpUCi1QNzbiTwo= X-Received: by 2002:a63:e310:: with SMTP id f16mr1466908pgh.160.1612481774565; Thu, 04 Feb 2021 15:36:14 -0800 (PST) Received: from harshads-520.kir.corp.google.com ([2620:15c:17:10:5142:d9c7:4222:def5]) by smtp.googlemail.com with ESMTPSA id mv14sm10236149pjb.0.2021.02.04.15.36.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 15:36:13 -0800 (PST) From: Harshad Shirwadkar X-Google-Original-From: Harshad Shirwadkar To: linux-ext4@vger.kernel.org Cc: tytso@mit.edu, Harshad Shirwadkar Subject: [PATCH 2/3] e2fsck: don't print errcode if the errcode is 0 Date: Thu, 4 Feb 2021 15:36:00 -0800 Message-Id: <20210204233601.2369470-2-harshads@google.com> X-Mailer: git-send-email 2.30.0.365.g02bc693789-goog In-Reply-To: <20210204233601.2369470-1-harshads@google.com> References: <20210204233601.2369470-1-harshads@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Harshad Shirwadkar We print the error message corresponding to errcode while converting errcode to errno. Don't do that if errcode is 0. Signed-off-by: Harshad Shirwadkar --- e2fsck/journal.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/e2fsck/journal.c b/e2fsck/journal.c index b1ca485c..922c252d 100644 --- a/e2fsck/journal.c +++ b/e2fsck/journal.c @@ -383,7 +383,9 @@ out_err: static int __errcode_to_errno(errcode_t err, const char *func, int line) { - fprintf(stderr, "Error \"%s\" encountered in %s at line %d\n", + if (err == 0) + return 0; + fprintf(stderr, "Error \"%s\" encountered in function %s at line %d\n", error_message(err), func, line); if (err <= 256) return -err; -- 2.30.0.365.g02bc693789-goog