Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3722099pxb; Sun, 7 Feb 2021 20:43:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJxmEP4Ocnbybc2lFCcF4kX1KdKiTez4GIo/ftLaaK3KMpRN+mIfzd2+JjEL2AUNH99CPq4B X-Received: by 2002:aa7:c7c8:: with SMTP id o8mr15418622eds.137.1612759406124; Sun, 07 Feb 2021 20:43:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612759406; cv=none; d=google.com; s=arc-20160816; b=YX3HFnKHEjPQdCw5HwQbC5nX4sUjV7IuaVV0za1i/m0SnHux7bhnicKImEldqEGdrF ZI+JXrzXt/QJdO+Ap+E09+6vn1TII/KN2K+PCqot1NbYSN4cLIYbnurbmK4lolc5YoXY S4yLd/NTsbHi9zufy7MnNFlPqrHjiJbMH7tQVePv+o/d7urWYccolN8wLqoK3fPX9GGg zXduj2rPca3AsFapQ0mAlKqg3haocm7tcJ3SjKP3wRjk87XDcbM+qr+aUYyOViJueV4Q MWRS3+LitzGZl+hSt4jDA4PznW2eaZrwfSB42D3kUPVDyDQmDFybDcOycTTblvVoDrpG jHqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=WB3juAaBYwC2MxbiotZSBmQXq1FFI9Dtko9ctx5zdno=; b=D6Fw8z1i5yI+NGHdTWewQ01+IpTNywgSuNXy29rkEj2W+iHJ33L8PRFBrgCjjglKRw 8jppVRf3nQThxz0IYVNt2tiIZ8yTCW408C7Ov0QrmqyzXJ2pVT2jy9cpgYviF47ktWGB ynejESYDj7LMTTwb/g7ltwF0Ji47DLBcAkvHvdUuyxdG+g+KcigVqqFbHcY1LNPuus3b rXbcw6/ScsP/mYb4f8LgXzarXbkjAUoSJh5ZmttTiscyNQSOUtnxS/b/eOu0k6e3TPlw DMfyXPam9R6D8R9QuGyOoda+tqdgeqKlEN+pj++O8q8LWP6OArN/nS9PjeLzMs9oXojL qWjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mf6si7097296ejb.132.2021.02.07.20.43.02; Sun, 07 Feb 2021 20:43:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229621AbhBHEms (ORCPT + 99 others); Sun, 7 Feb 2021 23:42:48 -0500 Received: from mga18.intel.com ([134.134.136.126]:13382 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbhBHEmr (ORCPT ); Sun, 7 Feb 2021 23:42:47 -0500 IronPort-SDR: BiH4qD6/hl3RMmH460ZSzQMM+thi9DIIPFRK7bMfPWvHXHPhbAirBBMZL18mkKmhDMU0w4PbXm DJphH0Srn1Ow== X-IronPort-AV: E=McAfee;i="6000,8403,9888"; a="169341982" X-IronPort-AV: E=Sophos;i="5.81,161,1610438400"; d="scan'208";a="169341982" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2021 20:42:05 -0800 IronPort-SDR: lDzmoh8+UisZyVs1ZdC9r6kw83BmFeBWP09Iyvk1+CUVLR3QZX6dMgmpSW6/pKun3V1xaUAOt7 PTdNFalIGYjw== X-IronPort-AV: E=Sophos;i="5.81,161,1610438400"; d="scan'208";a="376972543" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2021 20:42:05 -0800 Date: Sun, 7 Feb 2021 20:42:05 -0800 From: Ira Weiny To: Chaitanya Kulkarni Cc: "linux-block@vger.kernel.org" , "linux-ext4@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , "linux-fsdevel@vger.kernel.org" , "axboe@kernel.dk" , "tytso@mit.edu" , "adilger.kernel@dilger.ca" , "jaegeuk@kernel.org" , "chao@kernel.org" , Johannes Thumshirn , Damien Le Moal , "bvanassche@acm.org" , "dongli.zhang@oracle.com" , "clm@fb.com" , "dsterba@suse.com" , "ebiggers@kernel.org" , "hch@infradead.org" , "dave.hansen@intel.com" Subject: Re: [RFC PATCH 0/8] use core page calls instead of kmaps Message-ID: <20210208044205.GG5033@iweiny-DESK2.sc.intel.com> References: <20210207190425.38107-1-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1 (2018-12-01) Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sun, Feb 07, 2021 at 07:10:41PM +0000, Chaitanya Kulkarni wrote: > On 2/7/21 11:04, Chaitanya Kulkarni wrote: > > Chaitanya Kulkarni (8): > > brd: use memcpy_from_page() in copy_from_brd() > > brd: use memcpy_from_page() in copy_from_brd() > I'm aware that couple of places in brd code we can use memcpy_to_page() > and get rid the local variable, once I get some feedback I'll add those > to the V1. Except for the one comment I had this series look's good to me. Reviewed-by: Ira Weiny Thanks! Ira