Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: WAMmKfRw7YQw+pPXTDQXDFGcZH7HpGaREWozmv0D7Ajxl01lyMs18AwalYCSo5Dkq1QpyKQJiR
 u2RsCCV6e5+Wa/4x2AFbWfCazBFog29qHUv4KLBahrcUr/mIkGU9ElFZ6P9m52795xLWEgnRFP
 3TxPdZF5KBu6J91JnQTrqnbxfQQD46YibGw4i/jq/e1zZ6fGEVdLNcYdkTbwCmfjh2gyD0FW7X
 iZYckCNsx1IX7DuFEB1xjc/gVSVmWN35rbIxAPDKoLel/D+TJAE/QejFNji18G9RuSvCVD5dBZ
 RoQ=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Ira Weiny <ira.weiny@intel.com>
CC:     "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
        "linux-f2fs-devel@lists.sourceforge.net" 
        <linux-f2fs-devel@lists.sourceforge.net>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "tytso@mit.edu" <tytso@mit.edu>,
        "adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
        "jaegeuk@kernel.org" <jaegeuk@kernel.org>,
        "chao@kernel.org" <chao@kernel.org>,
        Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
        Damien Le Moal <Damien.LeMoal@wdc.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "dongli.zhang@oracle.com" <dongli.zhang@oracle.com>,
        "clm@fb.com" <clm@fb.com>, "dsterba@suse.com" <dsterba@suse.com>,
        "ebiggers@kernel.org" <ebiggers@kernel.org>,
        "hch@infradead.org" <hch@infradead.org>,
        "dave.hansen@intel.com" <dave.hansen@intel.com>
Subject: Re: [RFC PATCH 0/8] use core page calls instead of kmaps
Thread-Topic: [RFC PATCH 0/8] use core page calls instead of kmaps
Thread-Index: AQHW/YQRsjkxc1kvWUSrH/26RYB5ag==
Date:   Mon, 8 Feb 2021 05:47:20 +0000
Message-ID: <BYAPR04MB4965F228A130556639B17B85868F9@BYAPR04MB4965.namprd04.prod.outlook.com>
References: <20210207190425.38107-1-chaitanya.kulkarni@wdc.com>
 <BYAPR04MB49655721C8EE8BAFF055EE2986B09@BYAPR04MB4965.namprd04.prod.outlook.com>
 <20210208044205.GG5033@iweiny-DESK2.sc.intel.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 853d474d-e12a-43cd-d41c-08d8cbf5002d
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2021 05:47:20.2305
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SiTzrUcj+g6CSg762WOU8kLo97ld0EWITWtZXYOHvN6+vb0UEAuema23IXi7ohWa4vjaQ3IaH2ARiCMfTDLBcB4xeCPxl8qU/9VzBTVFo1w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4037
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On 2/7/21 20:42, Ira Weiny wrote:=0A=
> On Sun, Feb 07, 2021 at 07:10:41PM +0000, Chaitanya Kulkarni wrote:=0A=
>> On 2/7/21 11:04, Chaitanya Kulkarni wrote:=0A=
>>> Chaitanya Kulkarni (8):=0A=
>>>   brd: use memcpy_from_page() in copy_from_brd()=0A=
>>>   brd: use memcpy_from_page() in copy_from_brd()=0A=
>> I'm aware that couple of places in brd code we can use memcpy_to_page()=
=0A=
>> and get rid the local variable, once I get some feedback I'll add those=
=0A=
>> to the V1.=0A=
> Except for the one comment I had this series look's good to me.=0A=
>=0A=
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>=0A=
>=0A=
> Thanks!=0A=
> Ira=0A=
>=0A=
>=0A=
Thanks Ira, I'll add your fix in the V1 and send with your review-by tag,=
=0A=
when this code is upstream.=0A=
=0A=
Thanks a lot for doing this we can get rid of go in null_blk which makes=0A=
code smooth.=0A=