Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 8 Feb 2021 23:23:29 -0500
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Andreas Dilger <adilger@whamcloud.com>
Cc:     linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2fsck: fix check of directories over 4GB
Message-ID: <YCIOQSLElpGk9rKX@mit.edu>
References: <20210202082549.2936-1-adilger@whamcloud.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210202082549.2936-1-adilger@whamcloud.com>
Precedence: bulk

On Tue, Feb 02, 2021 at 01:25:49AM -0700, Andreas Dilger wrote:
> If directories grow larger than 4GB in size with the large_dir
> feature, e2fsck will consider them to be corrupted and clear
> the high bits of the size.
> 
> Since it isn't very common to have directories this large, and
> unlike sparse files that don't have ill effects if the size is
> too large, an too-large directory will have all of the sparse
> blocks filled in by e2fsck, so huge directories should still
> be viewed with suspicion.  Check for consistency between two of
> the three among block count, inode size, and superblock large_dir
> flag before deciding whether the directory inode should be fixed
> or cleared, or if large_dir should be set in the superblock.
> 
> Update the f_recnect_bad test case to match new output.
> 
> Fixes: 49f28a06b738 ("e2fsck: allow to check >2GB sized directory")
> Signed-off-by: Andreas Dilger <adilger@whamcloud.com>
> Lustre-bug-id: https://jira.whamcloud.com/browse/LU-14345
> Change-Id: I1b898cdab95d239ba1a7b37eb96255acadce7057

Thanks, applied.

						- Ted