Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp214834pxb; Mon, 8 Feb 2021 20:56:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJxhT4hmHVYxOgOQejL75pRi+nMaNmpdZEdjiPuYRqk16jaRZQnveDgz7GCZuWIhXATmXnfq X-Received: by 2002:a05:6402:190a:: with SMTP id e10mr20894863edz.110.1612846578709; Mon, 08 Feb 2021 20:56:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612846578; cv=none; d=google.com; s=arc-20160816; b=mNIiWT7Nwk3Ke/YP7MZiOCy8ee+sogxKFAdxewtgnYKSN1WQuqoZqgbh7h8QFUam53 29X+9ObSU3/Bn4f0U6lvmGfnUqmpkhviYEeRJ6OxtzXOhKi28cVJbxCkQKXEB1ynZy50 iVaBmRuhtUCDR30iKtMg9Lq34LYkN8w8w011V0p/eQ0XU2o094QzEt+cdCgtqsf470v2 xAvRQY9nKMOr1+WziUAcZyNwTx6/fkrUqgbFl9etPOD9MV33YUjpai/EsmfJEO0igYLa dohGw3tuOKnOeIzIJMQne8IRGW0sXIbIWfbyEiypDXLkQzOZHeLZOMpOYq2NE8QMGT6R mHKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=Ea1F7Lx0MCWfqsDCvARcY+AZXk6XfBArhiupmb7g5IQ=; b=R++iRdMirWNi+Y9KDxXCWaQTFwb8guvVAp4kWXn4AR9Ph/PGo9DqAty5LDiOxOsjtn W6IbqkconIyWO6pAfmvrjbUgXOKyR5B4hhhqjbvSyMYsGuRtDxd8s5qDCMyw/HEb1iJ1 Qb79rvx/C2sSqQXERYtYiEJvgQYtHB0damxzhxrlTZ+qawPqTOSMO87JRKuG4W/QjDEi JIDOjr72x1P++fi7UhtHoY9M1eTOEyTyW3saauK/Wdtv+yqhYTmXCjNHpXfLs1DjRR2r 51Q5YgkNT5o3WcRokYnFGWGU8zqodM/k4BmHzqFKBzQRzW6Ha7HSXRF0Ua5lejxICiUe +EWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m25si14641784eda.322.2021.02.08.20.55.44; Mon, 08 Feb 2021 20:56:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229783AbhBIEtv (ORCPT + 99 others); Mon, 8 Feb 2021 23:49:51 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:41110 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229671AbhBIEtu (ORCPT ); Mon, 8 Feb 2021 23:49:50 -0500 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 1194n1EN027530 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 8 Feb 2021 23:49:02 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 8F54E15C39D8; Mon, 8 Feb 2021 23:49:01 -0500 (EST) Date: Mon, 8 Feb 2021 23:49:01 -0500 From: "Theodore Ts'o" To: Harshad Shirwadkar Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH 3/3] e2fsck: endianness fixes for fast commit replay Message-ID: References: <20210204233601.2369470-1-harshads@google.com> <20210204233601.2369470-3-harshads@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210204233601.2369470-3-harshads@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Feb 04, 2021 at 03:36:01PM -0800, Harshad Shirwadkar wrote: > From: Harshad Shirwadkar > > There are a few places where the endianness conversion wasn't done > right. This patch fixes that. Verified that after this patch, > j_recover_fast_commit passes on big endian qemu VM. > > root@debian-powerpc:~/e2fsprogs/tests# make j_recover_fast_commit > j_recover_fast_commit: : ok > > Signed-off-by: Harshad Shirwadkar Thanks, applied. - Ted