Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp214835pxb; Mon, 8 Feb 2021 20:56:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJzBb/5gtDkMMtxtRImS8rms33hIqO7IKrgVhmT1Y0AvhMZyREy/vJSztDuxm2JjUqCMvHTt X-Received: by 2002:a17:906:2e85:: with SMTP id o5mr20176810eji.238.1612846578698; Mon, 08 Feb 2021 20:56:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612846578; cv=none; d=google.com; s=arc-20160816; b=H4llDfejOpL8OKANQFQK689Py7rnwS8TTSke9o8xr29UtMN0osqLLoc0yTUEtRN5o/ NZ/nipMOCg1jyghkQvWwAASIa2xwyXRl4MEqX3ehFqUyeg9xinHOzfHv0R5JgOsN5TOx 6eqVOmEnT8mJ0IUQ9ES8bY4puuxcpR1e7adddlG6HA2MfS/Oz9oFMmrqRWh4KPWRD05W ZGYpP6kQenxPcI5JGnoZM6nXqshXXOUHPboTxku53c6YLusvwlpz5Ol+AsVSnldeLOJu EvDqWYukQMr8bgbQ9mGVjITkyXeRAgPJSnevROtKEZZozxXXBLAmWEDbbDuoVgqzNHj5 Vo0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=KwiRnns4LrPK6w4c+TWsE+UWST5g25xzaVQ823E05zM=; b=x2Txw/wzGdqc/zF+X/6PXJt6UaYCaRP9pDcVn9l9siBZutJ/5BhfViebRvwY3rnh1N 0x9y/V0XmzeJgxxiwg4dApDe+WS4CNxviqn9ekBtEYh9iBI4F99oKWfWaZ6tKDw+qrrW Cd8fGJtVPZpKxnRdwYGttWqcorKPBKRSiHWQa0vLZjT2hkHah8q9h2fNW8LvVF+qGnIS 8m6lwqfj1q19y5rSS2ArD16H5DzHdVdB7jE3M+ivdC3/tbcZyJP8kp5zo4b0UPGI7xZw 0UglYuSHijnsyIqtKwhsB0T2e4kNeosKNLBHSjAxXjLkXEDeIN0yGOKg/naaT9d3Ljrs vzaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l21si10139463ejg.481.2021.02.08.20.55.44; Mon, 08 Feb 2021 20:56:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229824AbhBIEth (ORCPT + 99 others); Mon, 8 Feb 2021 23:49:37 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:41079 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229671AbhBIEth (ORCPT ); Mon, 8 Feb 2021 23:49:37 -0500 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 1194mlQZ027491 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 8 Feb 2021 23:48:48 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 8B36115C39D8; Mon, 8 Feb 2021 23:48:47 -0500 (EST) Date: Mon, 8 Feb 2021 23:48:47 -0500 From: "Theodore Ts'o" To: Harshad Shirwadkar Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH 2/3] e2fsck: don't print errcode if the errcode is 0 Message-ID: References: <20210204233601.2369470-1-harshads@google.com> <20210204233601.2369470-2-harshads@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210204233601.2369470-2-harshads@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Feb 04, 2021 at 03:36:00PM -0800, Harshad Shirwadkar wrote: > From: Harshad Shirwadkar > > We print the error message corresponding to errcode while converting > errcode to errno. Don't do that if errcode is 0. > > Signed-off-by: Harshad Shirwadkar It looks like this change is already in commit 63b7192cae60 ("e2fsck: add fc replay for link, unlink, creat tags") which is already in the upstream repo? - Ted