Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\))
Subject: Re: [PATCH v2 3/5] ext4: add MB_NUM_ORDERS macro
From:   =?utf-8?B?0JHQu9Cw0LPQvtC00LDRgNC10L3QutC+INCQ0YDRgtGR0Lw=?= 
        <artem.blagodarenko@gmail.com>
In-Reply-To: <20210209202857.4185846-4-harshadshirwadkar@gmail.com>
Date:   Tue, 16 Feb 2021 13:45:26 +0300
Cc:     linux-ext4@vger.kernel.org, "Theodore Y. Ts'o" <tytso@mit.edu>,
        bzzz@whamcloud.com, sihara@ddn.com,
        Andreas Dilger <adilger@dilger.ca>
Content-Transfer-Encoding: quoted-printable
Message-Id: <1029810C-1D3F-45ED-9EF3-EF85C31AE81B@gmail.com>
References: <20210209202857.4185846-1-harshadshirwadkar@gmail.com>
 <20210209202857.4185846-4-harshadshirwadkar@gmail.com>
To:     Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Precedence: bulk

Hello Harshad,

I believe there are two places yet there number could be changed to the =
macros

fs/ext4/mballoc.c <<ext4_mb_init_cache>>
             (sb->s_blocksize_bits+2));

fs/ext4/mballoc.c <<ext4_mb_good_group>>
if (ac->ac_2order > ac->ac_sb->s_blocksize_bits+1)

Best regards,
Artem Blagodarenko

> On 9 Feb 2021, at 23:28, Harshad Shirwadkar =
<harshadshirwadkar@gmail.com> wrote:
>=20
> A few arrays in mballoc.c use the total number of valid orders as
> their size. Currently, this value is set as "sb->s_blocksize_bits +
> 2". This makes code harder to read. So, instead add a new macro
> MB_NUM_ORDERS(sb) to make the code more readable.
>=20
> Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>
> ---
> fs/ext4/mballoc.c | 15 ++++++++-------
> fs/ext4/mballoc.h |  5 +++++
> 2 files changed, 13 insertions(+), 7 deletions(-)
>=20
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index fffd0770e930..b7f25120547d 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -756,7 +756,7 @@ mb_set_largest_free_order(struct super_block *sb, =
struct ext4_group_info *grp)
>=20
> 	grp->bb_largest_free_order =3D -1; /* uninit */
>=20
> -	bits =3D sb->s_blocksize_bits + 1;
> +	bits =3D MB_NUM_ORDERS(sb) - 1;
> 	for (i =3D bits; i >=3D 0; i--) {
> 		if (grp->bb_counters[i] > 0) {
> 			grp->bb_largest_free_order =3D i;
> @@ -1928,7 +1928,7 @@ void ext4_mb_simple_scan_group(struct =
ext4_allocation_context *ac,
> 	int max;
>=20
> 	BUG_ON(ac->ac_2order <=3D 0);
> -	for (i =3D ac->ac_2order; i <=3D sb->s_blocksize_bits + 1; i++) =
{
> +	for (i =3D ac->ac_2order; i < MB_NUM_ORDERS(sb); i++) {
> 		if (grp->bb_counters[i] =3D=3D 0)
> 			continue;
>=20
> @@ -2314,13 +2314,13 @@ ext4_mb_regular_allocator(struct =
ext4_allocation_context *ac)
> 	 * We also support searching for power-of-two requests only for
> 	 * requests upto maximum buddy size we have constructed.
> 	 */
> -	if (i >=3D sbi->s_mb_order2_reqs && i <=3D sb->s_blocksize_bits =
+ 2) {
> +	if (i >=3D sbi->s_mb_order2_reqs && i <=3D MB_NUM_ORDERS(sb)) {
> 		/*
> 		 * This should tell if fe_len is exactly power of 2
> 		 */
> 		if ((ac->ac_g_ex.fe_len & (~(1 << (i - 1)))) =3D=3D 0)
> 			ac->ac_2order =3D array_index_nospec(i - 1,
> -							   =
sb->s_blocksize_bits + 2);
> +							   =
MB_NUM_ORDERS(sb));
> 	}
>=20
> 	/* if stream allocation is enabled, use global goal */
> @@ -2850,7 +2850,7 @@ int ext4_mb_init(struct super_block *sb)
> 	unsigned max;
> 	int ret;
>=20
> -	i =3D (sb->s_blocksize_bits + 2) * sizeof(*sbi->s_mb_offsets);
> +	i =3D MB_NUM_ORDERS(sb) * sizeof(*sbi->s_mb_offsets);
>=20
> 	sbi->s_mb_offsets =3D kmalloc(i, GFP_KERNEL);
> 	if (sbi->s_mb_offsets =3D=3D NULL) {
> @@ -2858,7 +2858,7 @@ int ext4_mb_init(struct super_block *sb)
> 		goto out;
> 	}
>=20
> -	i =3D (sb->s_blocksize_bits + 2) * sizeof(*sbi->s_mb_maxs);
> +	i =3D MB_NUM_ORDERS(sb) * sizeof(*sbi->s_mb_maxs);
> 	sbi->s_mb_maxs =3D kmalloc(i, GFP_KERNEL);
> 	if (sbi->s_mb_maxs =3D=3D NULL) {
> 		ret =3D -ENOMEM;
> @@ -2884,7 +2884,8 @@ int ext4_mb_init(struct super_block *sb)
> 		offset_incr =3D offset_incr >> 1;
> 		max =3D max >> 1;
> 		i++;
> -	} while (i <=3D sb->s_blocksize_bits + 1);
> +	} while (i < MB_NUM_ORDERS(sb));
> +
>=20
> 	spin_lock_init(&sbi->s_md_lock);
> 	sbi->s_mb_free_pending =3D 0;
> diff --git a/fs/ext4/mballoc.h b/fs/ext4/mballoc.h
> index 7597330dbdf8..02861406932f 100644
> --- a/fs/ext4/mballoc.h
> +++ b/fs/ext4/mballoc.h
> @@ -78,6 +78,11 @@
>  */
> #define MB_DEFAULT_MAX_INODE_PREALLOC	512
>=20
> +/*
> + * Number of valid buddy orders
> + */
> +#define MB_NUM_ORDERS(sb)		((sb)->s_blocksize_bits + 2)
> +
> struct ext4_free_data {
> 	/* this links the free block information from sb_info */
> 	struct list_head		efd_list;
> --=20
> 2.30.0.478.g8a0d178c01-goog
>=20