Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\))
Subject: Re: [PATCH 1/4] e2fsck: don't ignore return values in
 e2fsck_rewrite_extent_tree
From:   =?utf-8?B?0JHQu9Cw0LPQvtC00LDRgNC10L3QutC+INCQ0YDRgtGR0Lw=?= 
        <artem.blagodarenko@gmail.com>
In-Reply-To: <20210219210333.1439525-1-harshads@google.com>
Date:   Sat, 20 Feb 2021 11:58:12 +0300
Cc:     linux-ext4@vger.kernel.org, tytso@mit.edu
Content-Transfer-Encoding: quoted-printable
Message-Id: <CAADEDFF-59C9-411A-93F3-BE1AEBE1CE39@gmail.com>
References: <20210219210333.1439525-1-harshads@google.com>
To:     Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Precedence: bulk

Hello Harshad,

ext2fs_iblk_set in the same e2fsck_rewrite_extent_tee returns a return =
code, but code is ignored.
Could you also add check there?

Best regards,
Artem Blagodarenko

> On 20 Feb 2021, at 00:03, Harshad Shirwadkar =
<harshadshirwadkar@gmail.com> wrote:
>=20
> From: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
>=20
> Don't ignore return values of ext2fs_read/write_inode_full() in
> e2fsck_rewrite_extent_tree.
>=20
> Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
> ---
> e2fsck/extents.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>=20
> diff --git a/e2fsck/extents.c b/e2fsck/extents.c
> index 600dbc97..f48f14ff 100644
> --- a/e2fsck/extents.c
> +++ b/e2fsck/extents.c
> @@ -290,8 +290,10 @@ errcode_t e2fsck_rewrite_extent_tree(e2fsck_t =
ctx, struct extent_list *list)
> 	errcode_t err;
>=20
> 	memset(&inode, 0, sizeof(inode));
> -	ext2fs_read_inode_full(ctx->fs, list->ino, EXT2_INODE(&inode),
> -				sizeof(inode));
> +	err =3D ext2fs_read_inode_full(ctx->fs, list->ino, =
EXT2_INODE(&inode),
> +				     sizeof(inode));
> +	if (err)
> +		return err;
>=20
> 	/* Skip deleted inodes and inline data files */
> 	if (inode.i_flags & EXT4_INLINE_DATA_FL)
> @@ -306,10 +308,8 @@ errcode_t e2fsck_rewrite_extent_tree(e2fsck_t =
ctx, struct extent_list *list)
> 	if (err)
> 		return err;
> 	ext2fs_iblk_set(ctx->fs, EXT2_INODE(&inode), blk_count);
> -	ext2fs_write_inode_full(ctx->fs, list->ino, EXT2_INODE(&inode),
> -		sizeof(inode));
> -
> -	return 0;
> +	return ext2fs_write_inode_full(ctx->fs, list->ino, =
EXT2_INODE(&inode),
> +				       sizeof(inode));
> }
>=20
> errcode_t e2fsck_read_extents(e2fsck_t ctx, struct extent_list =
*extents)
> --=20
> 2.30.0.617.g56c4b15f3c-goog
>=20