Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210219210333.1439525-1-harshads@google.com> <CAADEDFF-59C9-411A-93F3-BE1AEBE1CE39@gmail.com>
In-Reply-To: <CAADEDFF-59C9-411A-93F3-BE1AEBE1CE39@gmail.com>
From:   harshad shirwadkar <harshadshirwadkar@gmail.com>
Date:   Tue, 23 Feb 2021 09:40:41 -0800
Message-ID: <CAD+ocbzJRWg+iErcTmNhfsLiVPCs9dno6mWOE+1f7ekaCFs7LA@mail.gmail.com>
Subject: Re: [PATCH 1/4] e2fsck: don't ignore return values in e2fsck_rewrite_extent_tree
To:     =?UTF-8?B?0JHQu9Cw0LPQvtC00LDRgNC10L3QutC+INCQ0YDRgtGR0Lw=?= 
        <artem.blagodarenko@gmail.com>
Cc:     Ext4 Developers List <linux-ext4@vger.kernel.org>,
        "Theodore Y. Ts'o" <tytso@mit.edu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Thanks Artem, will fix this in V2.

- Harshad

On Sat, Feb 20, 2021 at 12:58 AM =D0=91=D0=BB=D0=B0=D0=B3=D0=BE=D0=B4=D0=B0=
=D1=80=D0=B5=D0=BD=D0=BA=D0=BE =D0=90=D1=80=D1=82=D1=91=D0=BC
<artem.blagodarenko@gmail.com> wrote:
>
> Hello Harshad,
>
> ext2fs_iblk_set in the same e2fsck_rewrite_extent_tee returns a return co=
de, but code is ignored.
> Could you also add check there?
>
> Best regards,
> Artem Blagodarenko
>
> > On 20 Feb 2021, at 00:03, Harshad Shirwadkar <harshadshirwadkar@gmail.c=
om> wrote:
> >
> > From: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
> >
> > Don't ignore return values of ext2fs_read/write_inode_full() in
> > e2fsck_rewrite_extent_tree.
> >
> > Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
> > ---
> > e2fsck/extents.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/e2fsck/extents.c b/e2fsck/extents.c
> > index 600dbc97..f48f14ff 100644
> > --- a/e2fsck/extents.c
> > +++ b/e2fsck/extents.c
> > @@ -290,8 +290,10 @@ errcode_t e2fsck_rewrite_extent_tree(e2fsck_t ctx,=
 struct extent_list *list)
> >       errcode_t err;
> >
> >       memset(&inode, 0, sizeof(inode));
> > -     ext2fs_read_inode_full(ctx->fs, list->ino, EXT2_INODE(&inode),
> > -                             sizeof(inode));
> > +     err =3D ext2fs_read_inode_full(ctx->fs, list->ino, EXT2_INODE(&in=
ode),
> > +                                  sizeof(inode));
> > +     if (err)
> > +             return err;
> >
> >       /* Skip deleted inodes and inline data files */
> >       if (inode.i_flags & EXT4_INLINE_DATA_FL)
> > @@ -306,10 +308,8 @@ errcode_t e2fsck_rewrite_extent_tree(e2fsck_t ctx,=
 struct extent_list *list)
> >       if (err)
> >               return err;
> >       ext2fs_iblk_set(ctx->fs, EXT2_INODE(&inode), blk_count);
> > -     ext2fs_write_inode_full(ctx->fs, list->ino, EXT2_INODE(&inode),
> > -             sizeof(inode));
> > -
> > -     return 0;
> > +     return ext2fs_write_inode_full(ctx->fs, list->ino, EXT2_INODE(&in=
ode),
> > +                                    sizeof(inode));
> > }
> >
> > errcode_t e2fsck_read_extents(e2fsck_t ctx, struct extent_list *extents=
)
> > --
> > 2.30.0.617.g56c4b15f3c-goog
> >
>