Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2558392pxb; Tue, 23 Feb 2021 09:44:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJwDoiHxgNPEdvO7UeuI60j2VIn55I//Xw4PNkgcIIb8CtW0X5vAyQRA4ClEFnrWR3enXMI8 X-Received: by 2002:a17:906:46d9:: with SMTP id k25mr5448801ejs.387.1614102277044; Tue, 23 Feb 2021 09:44:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614102277; cv=none; d=google.com; s=arc-20160816; b=b9G/HAmjgeKSDPEwjsxJVit619uzXX3PDkWXXMUAkfCfsKtoIww2JVIunodY5UCANK 2GBPtH6KAGXH+dh6nGdoHdo1bd0FAAk6SyRxSHcc7Lxla9nuO9hAXBydf9jLsHCEqqmp LH3YyHH6V7myQdUCmTdE36I7frQjr0pbSheHZ9PWTYiQEHdfXQ90Q3lul30GvGV1/FEW 3dd+Ui9iunMzIhZ7h6ZrmMtvl02rR/UsGbZNToM+dIHcI+kmSlOeh4b2yqSzOjdxeJp+ 2bmRPUZICLyA7oCOcNGJVaZN4bQ+AE1fBDsa6MG4+qCq3cDxkHKDVe6dAdWYpQHToCdZ qXuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=OQo1kj2nVSRFSSFkZ42zbMx/gberwXa3UDbaiFT879Q=; b=DtmfDrA0Oxmr6T4Y9X4RlkKgpS35zWBy4HMFL5IV7WyHqsnB7x3oJGKPsVmYRUIK+t tniD5rbXZhBR6NwZBdI9Ro5a24bPFEU+C8qSRbb8GbpkIt0TckDy5bGh+Y1gJleI5ksL 1ZuD24zN5N7ffF6Aqz/8bFXC1osZuHUNFxoxElrcsmWSKAZF/Izv1VCFHAi5U0Q9PaOi M3GP0YP1pawBiwG1I9oUIKOSS6Vfi4gdI8aD22z2iycFK6uOK1tNNiHfrKh2he7pdP2b gp2NWN23EFKXxm1eeV05+hLDrkmXZAmO5gkaeSTPL3rH1KuzarTfJuawvX+b0K2CKhxt 326A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OxhJgNmk; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m7si15148472edj.442.2021.02.23.09.44.12; Tue, 23 Feb 2021 09:44:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OxhJgNmk; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231696AbhBWRnB (ORCPT + 99 others); Tue, 23 Feb 2021 12:43:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230019AbhBWRnA (ORCPT ); Tue, 23 Feb 2021 12:43:00 -0500 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65E70C061786 for ; Tue, 23 Feb 2021 09:42:20 -0800 (PST) Received: by mail-pf1-x436.google.com with SMTP id r5so3286736pfh.13 for ; Tue, 23 Feb 2021 09:42:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=OQo1kj2nVSRFSSFkZ42zbMx/gberwXa3UDbaiFT879Q=; b=OxhJgNmkO0nSoeczR3+X5y/16xPmhltRjhVv3b6q+F9t49GPnXezU364jSHJeF5r6G CNFq3MBsNABfzCy1X/iMupTHBB2wDmwNOl+Wk9DAB04BJ93db5Tcne1J0XzRhMpaSrts SN2SaULlSQ7KpY42QDTjCpVEwJZh8xtk0o7toXbqkxZHqd3hoOHHnhes36jj/PAXzjqm aFWqbN3J47W8cxV6HwgR3jv1qR/r7wfQ1Syw0pWLh8tenWW4QKbLshhzcqu7qPoAeXp2 ujQ65UXL37WLTChg2ceaogffBQ1QZLJzc0bwlxxS8I2mZPc7su+uY3TRt1AosYvi1ICl hfBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=OQo1kj2nVSRFSSFkZ42zbMx/gberwXa3UDbaiFT879Q=; b=DuYDvNGL2zYDuIJlztp09svawiBHncbSOiRa+w4GXkk8SpVq3EQjsp2Fib+MFKx0NQ m3x8WM5eKpia/lk++xJP/cWK55AojQVMQxNA6h7WqTfrtf2A5sneL/il/+uHf6k4dBmO UJ1zPQBqATtSEbNCCFByb2hTHqE5ZB4/JKRhhRjOR8rw5lBtifEOKBq5PMvsumIf5bdU +tqN3rfbbiRXyQ6Uco4t2OFgFSXzNSzIV+q0DF855z2+Kn66d2AGB2iyc89mobHT005G uh9k5PujK7eRRYgG7UdCnO4TaGOXDKYBFTYvxq95C1MwURi1RGlk0LpqbuU38Y+F3fgM ldxw== X-Gm-Message-State: AOAM5304+ASr51876HBkdOtmBRpqGNAahbdnhf0OQIBamo8v5MOdByjR F3LO8WKuVGJWk9ZfViwgDN2YNp4yzq0= X-Received: by 2002:a63:141e:: with SMTP id u30mr8816880pgl.31.1614102139657; Tue, 23 Feb 2021 09:42:19 -0800 (PST) Received: from harshads-520.kir.corp.google.com ([2620:15c:17:10:9c60:903e:f56e:8b80]) by smtp.googlemail.com with ESMTPSA id gk14sm5527408pjb.2.2021.02.23.09.42.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Feb 2021 09:42:17 -0800 (PST) From: Harshad Shirwadkar X-Google-Original-From: Harshad Shirwadkar To: linux-ext4@vger.kernel.org Cc: tytso@mit.edu, Harshad Shirwadkar Subject: [PATCH v2 1/4] e2fsck: don't ignore return values in e2fsck_rewrite_extent_tree Date: Tue, 23 Feb 2021 09:41:53 -0800 Message-Id: <20210223174156.308507-1-harshads@google.com> X-Mailer: git-send-email 2.30.0.617.g56c4b15f3c-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Harshad Shirwadkar Don't ignore return values of library function calls in e2fsck_rewrite_extent_tree. Signed-off-by: Harshad Shirwadkar --- e2fsck/extents.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/e2fsck/extents.c b/e2fsck/extents.c index 600dbc97..018737af 100644 --- a/e2fsck/extents.c +++ b/e2fsck/extents.c @@ -290,8 +290,10 @@ errcode_t e2fsck_rewrite_extent_tree(e2fsck_t ctx, struct extent_list *list) errcode_t err; memset(&inode, 0, sizeof(inode)); - ext2fs_read_inode_full(ctx->fs, list->ino, EXT2_INODE(&inode), - sizeof(inode)); + err = ext2fs_read_inode_full(ctx->fs, list->ino, EXT2_INODE(&inode), + sizeof(inode)); + if (err) + return err; /* Skip deleted inodes and inline data files */ if (inode.i_flags & EXT4_INLINE_DATA_FL) @@ -305,11 +307,11 @@ errcode_t e2fsck_rewrite_extent_tree(e2fsck_t ctx, struct extent_list *list) &blk_count); if (err) return err; - ext2fs_iblk_set(ctx->fs, EXT2_INODE(&inode), blk_count); - ext2fs_write_inode_full(ctx->fs, list->ino, EXT2_INODE(&inode), - sizeof(inode)); - - return 0; + err = ext2fs_iblk_set(ctx->fs, EXT2_INODE(&inode), blk_count); + if (err) + return err; + return ext2fs_write_inode_full(ctx->fs, list->ino, EXT2_INODE(&inode), + sizeof(inode)); } errcode_t e2fsck_read_extents(e2fsck_t ctx, struct extent_list *extents) -- 2.30.0.617.g56c4b15f3c-goog