Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] misc: remove useless code in set_inode_xattr()
To:     <linux-ext4@vger.kernel.org>, "Theodore Y. Ts'o" <tytso@mit.edu>
CC:     harshad shirwadkar <harshadshirwadkar@gmail.com>,
        linfeilong <linfeilong@huawei.com>,
        lihaotian <lihaotian9@huawei.com>
References: <283210da-b281-2dd7-6ef7-b31e81e72e01@huawei.com>
From:   Zhiqiang Liu <liuzhiqiang26@huawei.com>
Message-ID: <0949867f-5ed8-6a51-1b8e-b116b833ef22@huawei.com>
Date:   Wed, 3 Mar 2021 08:51:14 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <283210da-b281-2dd7-6ef7-b31e81e72e01@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

ping...

On 2021/2/26 9:22, Zhiqiang Liu wrote:
> 
> In set_inode_xattr(), there are two returns as follows,
> -
>   return retval;
>   return 0;
> -
> Here, we remove useless 'return 0;' code.
> 
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
> ---
>  misc/create_inode.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/misc/create_inode.c b/misc/create_inode.c
> index 54d8d343..d62e1cb4 100644
> --- a/misc/create_inode.c
> +++ b/misc/create_inode.c
> @@ -234,7 +234,6 @@ static errcode_t set_inode_xattr(ext2_filsys fs, ext2_ino_t ino,
>  		retval = retval ? retval : close_retval;
>  	}
>  	return retval;
> -	return 0;
>  }
>  #else /* HAVE_LLISTXATTR */
>  static errcode_t set_inode_xattr(ext2_filsys fs EXT2FS_ATTR((unused)),
>