Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <F8991EA4-20AB-4785-83A6-8BC159EF3970@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_AB2605A8-A13B-4175-B9DA-6F452C1BFACB";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH] misc: remove useless code in set_inode_xattr()
Date:   Wed, 3 Mar 2021 13:20:33 -0700
In-Reply-To: <0949867f-5ed8-6a51-1b8e-b116b833ef22@huawei.com>
Cc:     linux-ext4@vger.kernel.org, "Theodore Y. Ts'o" <tytso@mit.edu>,
        harshad shirwadkar <harshadshirwadkar@gmail.com>,
        linfeilong <linfeilong@huawei.com>,
        lihaotian <lihaotian9@huawei.com>
To:     Zhiqiang Liu <liuzhiqiang26@huawei.com>
References: <283210da-b281-2dd7-6ef7-b31e81e72e01@huawei.com>
 <0949867f-5ed8-6a51-1b8e-b116b833ef22@huawei.com>
Precedence: bulk


--Apple-Mail=_AB2605A8-A13B-4175-B9DA-6F452C1BFACB
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On 2021/2/26 9:22, Zhiqiang Liu wrote:
>=20
> In set_inode_xattr(), there are two returns as follows,
> -
>  return retval;
>  return 0;
> -
> Here, we remove useless 'return 0;' code.
>=20
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> misc/create_inode.c | 1 -
> 1 file changed, 1 deletion(-)
>=20
> diff --git a/misc/create_inode.c b/misc/create_inode.c
> index 54d8d343..d62e1cb4 100644
> --- a/misc/create_inode.c
> +++ b/misc/create_inode.c
> @@ -234,7 +234,6 @@ static errcode_t set_inode_xattr(ext2_filsys fs, =
ext2_ino_t ino,
> 		retval =3D retval ? retval : close_retval;
> 	}
> 	return retval;
> -	return 0;
> }
> #else /* HAVE_LLISTXATTR */
> static errcode_t set_inode_xattr(ext2_filsys fs EXT2FS_ATTR((unused)),
>=20


Cheers, Andreas


--Apple-Mail=_AB2605A8-A13B-4175-B9DA-6F452C1BFACB
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAmA/75QACgkQcqXauRfM
H+CC9Q/+MKKSeAFCzBQEaWsBv3LHyHJ53sasd0dxjRVFUZQOTZj5Nr4DUip5uVbc
r9Ie7YfIOxakF2urUX0eE+R5Rnq6+6M+h5g+4DlyZaL42kCM8Qhx5m7fNKGnosgk
RnyMc4CYVWhWumsFzZX6aI0DnTc04EXVPw5GI2WfUNK+nqfzNsAxNe2hcpMJ1ZiO
u7RvU1BxoIIMsKuG470Ld1qUru8DB7s3hWS4p2goYyAcHlKC2XcIQdQ2y+AOT4Q8
ZE/3eVaMNFna6WKk4uj+XIKn67gXQ4s+M9UgagBj/vl2Amm9GekWhSwbSbG8sKqD
eKAMyYdW6ljkMhC31IZzPi4E+LPhnPRScSUPTaL8kENj1KX6VoLescqBjAhX01uI
wZXAXpqSTXXunnjJqtJC84DtEKAX6aaMbvx3Z+cOef32UXOTzXbz0KvnWl50dJ6k
MIQwU1HtoXP5bP4npZepfHcKDVIc8YIcQPsUqa5JlaXvXMjSKIT4kNhn8v6BZ/ML
cClC1Z0TFOIO9VsviRYr08dirKccP9WzigvC6XK6KHdw1TnR+U0mPq3MRQwfbm7R
WPgkzhQPAPR5kIdXEpatukiC8Aino6crCLBcl7Uu470XDoRDPG/enjSpBB+3+0Cq
pAeVpZZNBgJ7FlUhR7VvJAARgjjNldPmzTMd2/tAu7UIrRTSxvI=
=DmQ7
-----END PGP SIGNATURE-----

--Apple-Mail=_AB2605A8-A13B-4175-B9DA-6F452C1BFACB--