Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1765997pxf; Fri, 12 Mar 2021 19:45:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJx5CHaQ/eZQ7RgbT3162mME4zQRNlYUcrCWGH8Va1TbO+lYikTvjGJdt7GYpcTNN53j1KUK X-Received: by 2002:aa7:c6d2:: with SMTP id b18mr17756578eds.183.1615607125949; Fri, 12 Mar 2021 19:45:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615607125; cv=none; d=google.com; s=arc-20160816; b=dvL15WMAso20t5GtmQmCdgGM5xXUnrTYYTb1iM4Ef3IpL3r7L3+EkZYQJtxzftQXA7 qfoLq7QoMNTo4ltZEDkgjYerFGhvVtMixvh5BPSK3Ay3RmGAAJxyNdCH1rKGQRgbMZDv NieDWj0UO7/TbZ+trtzBYIgn0jOJp2sUTlstXy9g8dWzeHL6mMhuPicbsvlH0IQuk9e3 w7IatZlQpBp5Q4qin83zh7512Y0w2iD89Nm5a3bZPAE50gtp8PjfRM0fWYe3RhnxzyIh zCyqtKDLGXSb/21fDoqfdfBeVglwXwzuVELOMkbtWY8ZTJMnSZOrdbwdOO8mtFtFiXNE mcaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=CBNgQRKeBzdDifSEOgKTaiLunUuYSZ8882u6ppXU5+U=; b=lJQndBYSQ/QXUtF9OoEDd7jfU5YNAbMsOi1NS02VcMDpSScX4ijcsZWnAHW5ICEwE8 KWwnZv1AS0LlELzEsocHM6E2bJ9OiXjj5hoAWbemUdWxkMNDiGvs8/51upsP4sVX2z6P CRPrxNVrJ+YqQFBPu+gEEoUDBSJh9wGgF0JAwbjtref1ufoYiVvNUQ0ul5E2HBov7N26 BScVXMiRea+T/cxCanfUd5C1ZxxrAPrwG3JxqauyP+pxnRFwFN23+OcEoRc9Dp/Pmizo ABjLnTRH7DKP8EpCXx/th0rivw31x3OVId0hB+ryXFRyw/WxhShV7qagWeeDWc+zA9tW lzug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=eSqXv0ct; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gt5si5318905ejb.181.2021.03.12.19.44.47; Fri, 12 Mar 2021 19:45:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=eSqXv0ct; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233219AbhCMDhu (ORCPT + 99 others); Fri, 12 Mar 2021 22:37:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233233AbhCMDhb (ORCPT ); Fri, 12 Mar 2021 22:37:31 -0500 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 534ADC061574 for ; Fri, 12 Mar 2021 19:37:20 -0800 (PST) Received: by mail-pj1-x1036.google.com with SMTP id lr10-20020a17090b4b8ab02900dd61b95c5eso9400044pjb.4 for ; Fri, 12 Mar 2021 19:37:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CBNgQRKeBzdDifSEOgKTaiLunUuYSZ8882u6ppXU5+U=; b=eSqXv0ctfLqgigrMQ8PF9EWZOhecpDPODocztQkLMOQ9YOXCKxb6aGcV0SRFdGr9O/ SXAjhD1m4PZ2QeA9AwCL6vq4XZQZmY51dZDRKQwIU6B5X1V8i43Wcr1eTiYFEy5GkbB7 kxv7AI1W4IvaKAO8GXohAheVSCtalgLMdOlZUIIK4moC9F2R653fNXf0U4PRnDoC84HG JZRfjM1tgk/7SSX1LoxK7Sd6fP+7xCV3b9JRSbzKaM6zIHvtBfN2+OpqOGLfmNCv8hwp Z34rYUhez5+AFzOFoTMVxrKfhPizb9woR1sPWIEa5uCOST00D5h/UDN89crL5p23cZI1 hfTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CBNgQRKeBzdDifSEOgKTaiLunUuYSZ8882u6ppXU5+U=; b=RNqiwF9zZG0aeV0KelHloMmuH7E5YpGdlocglCskZxAI8TQnqyGhS/957tQ4kFDnum o9lA4LQ5bwKiYJ0RBLQh1CevsEX4bWOXBhtm8bJuiDoVgmUWbQZLeFhsQAhqmUfKREDS oiUbnrmt9g34eeqjk+ybJJiUKyrE27qFQOKvEFeyYQb75SJQQnzBjyQttrHeN7fhzJll Vl8A+fXNW/RFsf0su7Mq4kOcdAklbOLljBiUMNA9Rh9AjCf4U2uoRPSVVu2F/MrAfaXf f22E99ykqAeCQqSXwH+zMXl2JqbUZW+pflwKzS6N0EdIqxh7G1MTIm/hIbAXDrKT/x+/ W6vQ== X-Gm-Message-State: AOAM530daEif/DC4/pKAP0iDTj8X2QcmKZe4lqMVLqIwXVGJgQCOSRHV dDX/DQRHS2OGggSCns27ym8pxg== X-Received: by 2002:a17:90b:1213:: with SMTP id gl19mr1513866pjb.55.1615606639689; Fri, 12 Mar 2021 19:37:19 -0800 (PST) Received: from [192.168.1.134] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id j23sm6881761pfn.94.2021.03.12.19.37.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Mar 2021 19:37:19 -0800 (PST) Subject: Re: [RFC PATCH 0/3] block_dump: remove block dump To: "zhangyi (F)" , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-block@vger.kernel.org, jack@suse.cz Cc: tytso@mit.edu, viro@zeniv.linux.org.uk, hch@infradead.org, mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com References: <20210313030146.2882027-1-yi.zhang@huawei.com> From: Jens Axboe Message-ID: <15f9c6ce-f22a-59cd-8ce7-eb908f663826@kernel.dk> Date: Fri, 12 Mar 2021 20:37:17 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210313030146.2882027-1-yi.zhang@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 3/12/21 8:01 PM, zhangyi (F) wrote: > Hi, > > block_dump is an old debugging interface and can be replaced by > tracepoints, and we also found a deadlock issue relate to it[1]. As Jan > suggested, this patch set delete the whole block_dump feature, we can > use tracepoints to get the similar information. If someone still using > this feature cannot switch to use tracepoints or any other suggestions, > please let us know. Totally agree, that's long overdue. The feature is no longer useful and has been deprecated by much better methods. Unless anyone objects, I'll queue this up for 5.13. -- Jens Axboe