Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3624723pxf; Mon, 15 Mar 2021 14:10:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxH0dQmPWTcv1mPz41zTisHdLDq+3tXWM4j6o7ETk8Cohr9o1TrGyRzA6IGTcjKH+xxZGBO X-Received: by 2002:aa7:cd54:: with SMTP id v20mr32482888edw.80.1615842653047; Mon, 15 Mar 2021 14:10:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615842653; cv=none; d=google.com; s=arc-20160816; b=Yxi++k15HlG46mO5Wfhufuxh89LHcBLYJAOEhnsrIvDZHQY6og/dI1gucS6p9syXFH 7mnHxPvCQUVNhxGWlRtfz0EYhL7m52gLBrqr6JVz/rPhgH+PMFcLxakG/StpFmFCWCnl xeR6iH2I2UCUZC587zZDF0z7ExM0QD32js25lNStb60INyAJ/Y0DYqFoH3vXgJHjVlIG 5i3G7zHuWRwNfk8/SSvlW3iz0LcYcXh1PTxi0V3uKVUMDY1jy1tUb66PbRz1nuJBkr8N yY4Xqrz+MNJYc9v/pfYXlBNYXYmoFI9cTC1yO/1OtiCXIWiw5f0KRr06KoYsmgbFNOVE FSQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4CiZLIYw6bmdPB3ZMW7hHqURYy162uSVmUqoNibdWoc=; b=zoACbUvJKMkprTYincBANEA0T0kneFUGYsLewv6bWv9Ok9E5QOAsSlL4W9tTS9Up2r jtHg5JH8/I2xU0BuyKrpJpQ/D+Mzx+J/FMBo36m5nnrQN2qUsg8vBUW1IFo2Dm/GW13U OJOooffSk1zvabZdGOtlTEvg6dcnuP7qWTGm2M5dKqANF35gaJO0v9Zm5aQxZUI+lwEA w6ecZPMOeX3ECUSInnYX6+S1c2dtVTqo/grjVzLouKixlpPIcM2gJ2sEsB9Exq1jllF7 zo4bkjCPMh8GkOw+5xV6CdUOcfGmTCMGrQpgmfvzc3vFYG+EgyiYh1+FtdKDGlyvPLFr JU0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=b1+uTYBp; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hb37si12138571ejc.81.2021.03.15.14.10.24; Mon, 15 Mar 2021 14:10:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=b1+uTYBp; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232943AbhCOTGd (ORCPT + 99 others); Mon, 15 Mar 2021 15:06:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232937AbhCOTGc (ORCPT ); Mon, 15 Mar 2021 15:06:32 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCC75C06174A for ; Mon, 15 Mar 2021 12:06:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4CiZLIYw6bmdPB3ZMW7hHqURYy162uSVmUqoNibdWoc=; b=b1+uTYBprlx5trah0j0kHToSvW zPl4w9nIirskKi7m6g/vDTOjJe3SmRLrQW29VkczPte/bQleEQOaD3H4/RrNb25Jt3yk0q9DPwI6/ 1VAlgqZzG2mafuD6EPWFOp5gQZKgyMoCSR0Ls+vBDBHJtTXuL4AFJOHHAljgc1Ruxx+Zogq8TDM1r 4lxHg4d3gDhQ6SxbDYYZYNTzvtCNaXscvLdP341c/irIeqbhd08kYO0MQmnyLyRHQBfmr3qCaTet2 Zg1rNGBZGup+efJa20wIt1LMHYhAEc9GZVFVZzvunKY265v3QXS1x6DwbKIsrv/6Roj7cPlsOUVxH FGK50d+Q==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lLsXi-000dR7-8Z; Mon, 15 Mar 2021 19:06:20 +0000 Date: Mon, 15 Mar 2021 19:06:18 +0000 From: Christoph Hellwig To: Harshad Shirwadkar Cc: linux-ext4@vger.kernel.org, tytso@mit.edu Subject: Re: [PATCH v4 2/6] ext4: add ability to return parsed options from parse_options Message-ID: <20210315190618.GA150808@infradead.org> References: <20210315173716.360726-1-harshadshirwadkar@gmail.com> <20210315173716.360726-3-harshadshirwadkar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210315173716.360726-3-harshadshirwadkar@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Mar 15, 2021 at 10:37:12AM -0700, Harshad Shirwadkar wrote: > Before this patch, the function parse_options() was returning > journal_devnum and journal_ioprio variables to the caller. This patch > generalizes that interface to allow parse_options to return any parsed > options to return back to the caller. In this patch series, it gets > used to capture the value of "mb_optimize_scan=%u" mount option. Instead of adding more code to the legacy option parsing code can someone convert ext4 to the new mount API first?