Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <C365A06E-B5FD-46D6-8B1C-6EC91B4CB6EF@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_CB8C92FC-EB48-4063-BDBB-F8DDE775D396";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: Block allocator improvements
Date:   Mon, 15 Mar 2021 13:52:21 -0600
In-Reply-To: <20210315173716.360726-1-harshadshirwadkar@gmail.com>
Cc:     linux-ext4@vger.kernel.org, tytso@mit.edu
To:     Harshad Shirwadkar <harshadshirwadkar@gmail.com>
References: <20210315173716.360726-1-harshadshirwadkar@gmail.com>
Precedence: bulk


--Apple-Mail=_CB8C92FC-EB48-4063-BDBB-F8DDE775D396
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Mar 15, 2021, at 11:37 AM, Harshad Shirwadkar =
<harshadshirwadkar@gmail.com> wrote:
>=20
> Created a highly fragmented disk of size 65TB. The disk had no
> contiguous 2M regions. Following command was run consecutively for 3
> times:
>=20
> time dd if=3D/dev/urandom of=3Dfile bs=3D2M count=3D10
>=20
> Here are the results with and without cr 0/1 optimizations:
>=20
> |---------+------------------------------+---------------------------|
> |         | Without CR 0/1 Optimizations | With CR 0/1 Optimizations |
> |---------+------------------------------+---------------------------|
> | 1st run | 5m1.871s                     | 2m47.642s                 |
> | 2nd run | 2m28.390s                    | 0m0.611s                  |
> | 3rd run | 2m26.530s                    | 0m1.255s                  |
> |---------+------------------------------+---------------------------|

IMHO, it would be useful to include this into the 5/6 patch commit
message, so that it is available with the patch in the future.
That will show the workload and basic test environment used to
justify this change, in case there are problems/changes in the future.

Cheers, Andreas


--Apple-Mail=_CB8C92FC-EB48-4063-BDBB-F8DDE775D396
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAmBPuvYACgkQcqXauRfM
H+CfmQ/9EeQ6wJd9v13Pj7JnxYJ6hOfbZ6ZPgxS+amKc4y4fxGsgbjOwThzcZ7S3
6iwwPTUI26CrBaeOLazkEhFryYdRkZYekP6NDSJEmxVTKdDeLZs+KyjkedxmpSJ9
RkD7RwK2i8leksLQcomVpKQEzi2PYvkFwuLzve6ltANVgyK081sIqIWbfqe5//Zf
HEEaex9Ip7XGv9KUH1B+5P1DyfLZqB//glcPpJmYTGw/zNS7QE2VyB1/K3OM+0XX
ndtqTCcj57ciCl4U5B6jhJdvI0y0uCJpJRsTQyuD4wT6Z34Xp2gvdzREZCaBdvVP
A7yxvnIl8DR9q2riK2u5e6gOytj985/MSfsEXPirOVxsi8olRU8geRsrbzpqDxme
ZvQ+6c+9ysVfBSqR+B3G6U/HT2umZYWPa+IC+Il+7LdG151jJClYSSyAu76dOF3b
DCF4Yk/mLL/hNNdXeAdD2DkA8Gxra6BfZs+spX+BEEUYbTKXzm5/9/QbI2MfXQKG
dQzX/TD5Kfihga2X1KRqBLFSISw9d91L55IPYp2qbpuLTSB+9dV4mw3kS43Dcpqv
+mebHbgSXQ8Ywa5CLVHhC5Ocqu2Lxhcg4CKCG94KW/CK9CHTixrmW7y/4WTG28ey
5wv2EYm4TsLhLG+UHOuoHIfvvASvR6de9lFnXTijhUTIhs4sB1E=
=6Rag
-----END PGP SIGNATURE-----

--Apple-Mail=_CB8C92FC-EB48-4063-BDBB-F8DDE775D396--