Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 21 Mar 2021 00:26:08 -0400
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Jan Kara <jack@suse.cz>
Cc:     Shijie Luo <luoshijie1@huawei.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: fix potential error in ext4_do_update_inode
Message-ID: <YFbK4JU5k1zAcA2f@mit.edu>
References: <20210312065051.36314-1-luoshijie1@huawei.com>
 <20210312125055.GB31816@quack2.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210312125055.GB31816@quack2.suse.cz>
Precedence: bulk

On Fri, Mar 12, 2021 at 01:50:55PM +0100, Jan Kara wrote:
> On Fri 12-03-21 01:50:51, Shijie Luo wrote:
> > If set_large_file = 1 and errors occur in ext4_handle_dirty_metadata(),
> > the error code will be overridden, go to out_brelse to avoid this
> > situation.
> > 
> > Signed-off-by: Shijie Luo <luoshijie1@huawei.com>
> 
> Yeah, looks good. Once ext4_handle_dirty_metadata() fails, the journal is
> aborted anyway so we are unlikely to do anything useful with the
> filesystem. Feel free to add:
> 
> Reviewed-by: Jan Kara <jack@suse.cz>

Thanks, applied.

					- Ted