Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <7103B623-9FD2-4BD2-8A44-8DBE38DFE291@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_4B471937-B0F3-40E7-8F95-16FF8433D279";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH] ext4: Fix ext4_error_err save negative errno into
 superblock
Date:   Thu, 1 Apr 2021 19:11:57 -0600
In-Reply-To: <20210401072234.3338057-1-yebin10@huawei.com>
Cc:     "Theodore Y. Ts'o" <tytso@mit.edu>,
        Ext4 Developers List <linux-ext4@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Liu Zhi Qiang <liuzhiqiang26@huawei.com>
To:     Ye Bin <yebin10@huawei.com>
References: <20210401072234.3338057-1-yebin10@huawei.com>
Precedence: bulk


--Apple-Mail=_4B471937-B0F3-40E7-8F95-16FF8433D279
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

On Apr 1, 2021, at 1:22 AM, Ye Bin <yebin10@huawei.com> wrote:
> 
> As read_mmp_block return 1 when failed, so just pass retval to
> save_error_info.

Thank you for submitting this patch, but it should not be accepted.

The commit message is confusing, since the code being changed relates
to retval from write_mmp_block().  That currently returns 1, but
only until your next patch is applied.

I think it is better to fix write_mmp_block() as in your next patch
to return a negative value to be more consistent with other code.

Cheers, Andreas

> Fixes: 54d3adbc29f0 ("ext4: save all error info in save_error_info() and
> drop ext4_set_errno()")
> Reported-by: Liu Zhi Qiang <liuzhiqiang26@huawei.com>
> Signed-off-by: Ye Bin <yebin10@huawei.com>
> ---
> fs/ext4/mmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c
> index 795c3ff2907c..bb8353e25841 100644
> --- a/fs/ext4/mmp.c
> +++ b/fs/ext4/mmp.c
> @@ -171,7 +171,7 @@ static int kmmpd(void *data)
> 		 */
> 		if (retval) {
> 			if ((failed_writes % 60) == 0) {
> -				ext4_error_err(sb, -retval,
> +				ext4_error_err(sb, retval,
> 					       "Error writing to MMP block");
> 			}
> 			failed_writes++;
> --
> 2.25.4
> 


Cheers, Andreas


--Apple-Mail=_4B471937-B0F3-40E7-8F95-16FF8433D279
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAmBmb10ACgkQcqXauRfM
H+DN0w/+NNJTjEwtEZ2M4JU4O/swJYTPZRF8xJcn4A6siay+ty2jxadixjbCK8l4
7u7+7w9E+Ie6aPaq4b9QWwPkCE0gfR6BXVMQBV7bB+XNVnjOJzLlvVGSoaTH6FGa
f+JGSFDblAAK/uJLZu53mnwRioqmq/WP9xU26FplLbhAJ8QtyfLgN83/6zxnPjvI
MDQT6BhzdNHHCKOW/BgKKgo6GGJLL8gnFqjizoyd2kmrmtIjKDCWvNAdlN0PRnX7
6C/dVI0S6yQYiu8yCi+lQ2MCOB2TaZPIYCAM24KSRm8v4xyVLKFYThp+g0ZN6lUW
uFAyT9F/i/gRpzO2Va11hJy1RNDdsc/KFtQ0mUu2X3zGi9VZOc/MyUUUG10u+xYj
lo/VQWNI30p2Vki5o7a0wgHehvixwvsFiX+cwTl63NI9sJCY2AQbos7uM00wpH0k
ndHGX6ITDXfUiHoYqdFTqNhtZBsS3xK1CaFB0GjG/fD15kXF6cYqn08i7h3tcDT2
+P593M+jit1IvMTebzAtvHmBIhj+i4p1HggJjijsXaJN7VI8yjjuJh/Yyb9nMkZS
SSnHANSRyGBHlddX8tzwCTafAx6v5/O6Q01Q+jIeiy91jrSNJBlit4tgrJuufZiW
ANy4l4phLr48/bucl+o030FqlzA61dhIabElNGZodoOPI6URYno=
=fqAO
-----END PGP SIGNATURE-----

--Apple-Mail=_4B471937-B0F3-40E7-8F95-16FF8433D279--