Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <FC1C6625-2E89-4547-B2E4-2D992181309D@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_53BD9715-8557-487D-A7E2-C2F5CB7C369C";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH v2] ext4: Fix ext4_error_err save negative errno into
 superblock
Date:   Thu, 1 Apr 2021 19:21:58 -0600
In-Reply-To: <20210401074017.3382721-1-yebin10@huawei.com>
Cc:     "Theodore Y. Ts'o" <tytso@mit.edu>,
        Ext4 Developers List <linux-ext4@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Liu Zhi Qiang <liuzhiqiang26@huawei.com>
To:     Ye Bin <yebin10@huawei.com>
References: <20210401074017.3382721-1-yebin10@huawei.com>
Precedence: bulk


--Apple-Mail=_53BD9715-8557-487D-A7E2-C2F5CB7C369C
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Apr 1, 2021, at 1:40 AM, Ye Bin <yebin10@huawei.com> wrote:
>=20
> As read_mmp_block return 1 when failed. read_mmp_block return -EIO =
when buffer
> isn't uptodate.

Thank you for this second patch.  Unfortunately, the commit message
is still confusing/incorrect because it references read_mmp_block()
in the first usage but is actually changing write_mmp_block().

With that change you could add a Reviewed-by label from me.

Cheers, Andreas

> Fixes: 54d3adbc29f0 ("ext4: save all error info in save_error_info() =
and
> drop ext4_set_errno()")
> Reported-by: Liu Zhi Qiang <liuzhiqiang26@huawei.com>
> Signed-off-by: Ye Bin <yebin10@huawei.com>
> ---
> fs/ext4/mmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c
> index 795c3ff2907c..68fbeedd627b 100644
> --- a/fs/ext4/mmp.c
> +++ b/fs/ext4/mmp.c
> @@ -56,7 +56,7 @@ static int write_mmp_block(struct super_block *sb, =
struct buffer_head *bh)
> 	wait_on_buffer(bh);
> 	sb_end_write(sb);
> 	if (unlikely(!buffer_uptodate(bh)))
> -		return 1;
> +		return -EIO;
>=20
> 	return 0;
> }
> --
> 2.25.4
>=20


Cheers, Andreas


--Apple-Mail=_53BD9715-8557-487D-A7E2-C2F5CB7C369C
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAmBmcbcACgkQcqXauRfM
H+Bgzg//WtpR3UQKASYF8Bu8cj7yHzoJC9CQwMcpojKCwcxDHboEXX9z7c9ia0sf
e6sr7nMOJygOL+rS3QdR78fDI3xvaK+wbR1qZNBbCLBffEJ/13ry5YI5YezRIdfe
hz9dhlMwT0WiniB3CpF7fb0/Fs/p30ud7u59Y3yrEMMCdr/WMkMtDs6v2BMZwmMN
K6aR4DaOC9+mF+KjyW25+l4eJgfzS7dja7WiewvP8xfmtSAISHQkIjh/EYRvf1lo
dQ2SW0yDsYrTuefVukavHhKk3dBHBUkKpwBpThcyrfzNdejUJPnpTwQ0YdFNcqRx
9fo9oiMbC4kvmTX4GrHPKYsnr9wYyDLp+uj64kikObUzoO0mDm3mT8c5drAC8vu3
rtmiO4Nze3BpieQYVdgnBHsbxmUWt207gBn/6rjSnuzeWtFIsZFq/CNaFVphHotF
Ma0TC7JDbimaJqusQZ6LGzFx5E0xOZ7Job6En3HVEmwDrbz7yP3ktqxAvwDM/hpZ
V8Bd44OO09mYb73API7AFjVdAG6ZjE26AMfnR1ShIAyJP8EwLioNaanNu+MY4Lcs
+TvIbcZciWnVoCIlOwdLAMAUBqsc7w5AoXBNZ5qrZwRmqGRt4LvC9f7luRrZHiBl
ZCYUjNcxG9s+slUO8MMwwQkA41rfWHYDAQs/uZSX7ZTMf72Sw44=
=/tep
-----END PGP SIGNATURE-----

--Apple-Mail=_53BD9715-8557-487D-A7E2-C2F5CB7C369C--