Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   <changfengnan@vivo.com>
To:     <tytso@mit.edu>, <adilger.kernel@dilger.ca>,
        <linux-ext4@vger.kernel.org>
References: <20210329035800.648-1-changfengnan@vivo.com>
In-Reply-To: <20210329035800.648-1-changfengnan@vivo.com>
Subject: =?gb2312?B?tPC4tDogW1BBVENIXSBleHQ0OiBmaXggZXJyb3IgY29kZSBpbiBleHQ0X2M=?=
        =?gb2312?B?b21taXRfc3VwZXI=?=
Date:   Fri, 2 Apr 2021 11:32:35 +0800
Message-ID: <000801d72770$d3f4b890$7bde29b0$@vivo.com>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="gb2312"
Content-Transfer-Encoding: 8BIT
Thread-Index: AQKGikBhgiQAULD/1R54Z6dLmieg46lBzKFQ
Content-Language: zh-cn
Precedence: bulk

Is there any problem with this patch? I did not see a reply, please let me
know if there is a problem. Thanks

-----?ʼ?ԭ??-----
??????: Fengnan Chang <changfengnan@vivo.com> 
????ʱ??: 2021??3??29?? 11:58
?ռ???: tytso@mit.edu; adilger.kernel@dilger.ca; linux-ext4@vger.kernel.org
????: Fengnan Chang <changfengnan@vivo.com>
????: [PATCH] ext4: fix error code in ext4_commit_super

We should set the error code when ext4_commit_super check argument failed.

Signed-off-by: Fengnan Chang <changfengnan@vivo.com>
---
 fs/ext4/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c index
03373471131c..5440b8ff86a8 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -5501,7 +5501,7 @@ static int ext4_commit_super(struct super_block *sb,
int sync)
 	int error = 0;

 	if (!sbh || block_device_ejected(sb))
-		return error;
+		return -EINVAL;

 	/*
 	 * If the file system is mounted read-only, don't update the
--
2.29.0