Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1370233pxf; Fri, 2 Apr 2021 08:41:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzUEKlR39iRxDhhEjwX43lpTvKyBIZ44gTFaadpQH+y4bqrvzDTP7/mJV5wJ7mhpdcUX5rp X-Received: by 2002:a17:906:4055:: with SMTP id y21mr14315950ejj.507.1617378092256; Fri, 02 Apr 2021 08:41:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617378092; cv=none; d=google.com; s=arc-20160816; b=P7+RrL6wpr4wD6rmZBK5d8uyuxmCmTWw8mtzDbzMYQx3VYbhf7iACVIovUiLcojcgD E2HLbpTDXPip/esUYLWTz5kRVG/LdYsrDjFviR2NAHUcOuy6M6Hjg3CeHSVN07kbu52x SuERaLiknXfc7y3y1mwCYEqfI2kBCgzTWt4glssOzp48M1cRdQflGfK/WIjKanKLUHYJ hcXbGZ+R1HtCaZ0KBAlTZhqOIYxdXsqa6HUu57ISnl/7QD9e0lP7fnxBgeVHOiMz8JJ9 qcUHAmYHNkZP+2kcEvIM44TmLd1qgWcrQjCgxjhQo+Ogsx4GF1wZT3uHBS36P+L0iLAh rlDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=jqv6RHgGmLJjtcdMDyB7d0mcl7L86lvN4ICRQ7sqIfo=; b=s66rYmOdWa1fTgtRCoot8JgrOF29eljAnaeht8yITEAPOQnEEGYzIuw3/4qhMvsnMx mK3ZhDfBnusRu8V7T+LBiwA+gcCoe8V4QvD7j4RetYOLmrG4+UFbUKfrUkH64uvqTVGe 9zK1zoU2NV2lF6QU721lMvzOJkf4vpPUga9PSnHGftZnnqCvQp1MjV0akKUpIKWukdOg jibptCWv/JKvICVoWX1ic9X19WNngaXxKh/gu3+FDtIqKptah96mDfDQy33+nka/SHjj lJySsLM56bgNCKL5V39gpPyqXvTS4g7IhZwK6d/6ac2hYGjrE9yxr31bhLBRMdB/ywO8 WASQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id co27si6580051edb.376.2021.04.02.08.41.03; Fri, 02 Apr 2021 08:41:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235304AbhDBPkd (ORCPT + 99 others); Fri, 2 Apr 2021 11:40:33 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:60117 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229553AbhDBPkd (ORCPT ); Fri, 2 Apr 2021 11:40:33 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 132FeJh5012338 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 2 Apr 2021 11:40:20 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id A873C15C3AC7; Fri, 2 Apr 2021 11:40:19 -0400 (EDT) Date: Fri, 2 Apr 2021 11:40:19 -0400 From: "Theodore Ts'o" To: Alexander Lochmann Cc: Jan Kara , Horst Schirmeier , Jan Kara , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Updated locking documentation for journal_t Message-ID: References: <20210210095740.54881-1-alexander.lochmann@tu-dortmund.de> <20210211093754.GJ19070@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Feb 11, 2021 at 10:51:55AM +0100, Alexander Lochmann wrote: > Some members of transaction_t are allowed to be read without > any lock being held if consistency doesn't matter. > Based on LockDoc's findings, we extended the locking > documentation of those members. > Each one of them is marked with a short comment: > "no lock for quick racy checks". > > Signed-off-by: Alexander Lochmann > Signed-off-by: Horst Schirmeier > Reviewed-by: Jan Kara Thanks, applied. I had to fix up the patch, which was mailer-damaged, and I also reflowed the comments. - Ted