Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1521604pxf; Fri, 2 Apr 2021 12:58:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcqjt+8TcOlBxYHKzyne1I5FUZKHS8pHZ4gR303jXsqvWv9NtKCymj7Vm03n6E0QI3ry8B X-Received: by 2002:a17:906:1fd6:: with SMTP id e22mr15978777ejt.481.1617393520887; Fri, 02 Apr 2021 12:58:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617393520; cv=none; d=google.com; s=arc-20160816; b=BItVdUH72QC73AeMKjndmAvc4SLrtziR9VstXWgJ/QUzmFVooJ33bj81qCmPEY866N QCIJT9knmwK4vukkUKIPXuGZIid5iqMiKvJIuNW9U63YEAoTG7vibllk0cofx7r/oAmk ohdD0e32TsTEJPdC8MdqqgAVxYPpRoYe3QGqUEMlNTUdpeaUiKYIJ51d3nYpUPBpWetQ eHoprG6Ye1ZLjYZQty3g1sOGKu7/XUeQq6oRT11sLZM4pxfYBkGK+LHeEH3EiJLIHCJ7 OW0qv4/x0AMjth9mCI2be0ycJJsXeYUCAbAf0ciooOHYjIatOhZKeHZCIWpPj0WJR6Fa 1T0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=2SzHwBx4K0iGERrYs//a9E2bu5JGyWXjtjC0ywFVHEQ=; b=j8wr1Rg2Du6OMC1iizjxQUaHyx/lPaTbHp40Ituh/rzF4sUw6OVxsBVSrHPkdHGONN 3CZcoNbYVR6GRPpA6+NABUHx+QcyVVuajOpAQFDZWAvFGuMXeSriBtydOWWMr4cZdnXf Acc47a54hHuDbmJ9nNYRPnI+JDhxWVOazjgWd84NX6zmcohWWDBVBnEX3xYZO3KDgTqM jgcq33rpIkRZuH1xKSeEWlYo23LIYDT9NPJ8b18AxI/VulloSjD2DAO48N4Fy0RaIF70 Q5aRQGsvhHI9ZPS0JabXhMAXXo7cLQUlBtOZAQQ15I1h4ZQUWJHXw84GriOQAYN82st6 7kmA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z15si7443558edr.361.2021.04.02.12.58.10; Fri, 02 Apr 2021 12:58:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236574AbhDBT5j (ORCPT + 99 others); Fri, 2 Apr 2021 15:57:39 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:53391 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229647AbhDBT5i (ORCPT ); Fri, 2 Apr 2021 15:57:38 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 132JvQB6026417 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 2 Apr 2021 15:57:26 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 2D69115C3ACE; Fri, 2 Apr 2021 15:57:26 -0400 (EDT) Date: Fri, 2 Apr 2021 15:57:26 -0400 From: "Theodore Ts'o" To: Andreas Dilger Cc: Zhiqiang Liu , linux-ext4@vger.kernel.org, harshad shirwadkar , linfeilong , lihaotian Subject: Re: [PATCH] misc: remove useless code in set_inode_xattr() Message-ID: References: <283210da-b281-2dd7-6ef7-b31e81e72e01@huawei.com> <0949867f-5ed8-6a51-1b8e-b116b833ef22@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Mar 03, 2021 at 01:20:33PM -0700, Andreas Dilger wrote: > On 2021/2/26 9:22, Zhiqiang Liu wrote: > > > > In set_inode_xattr(), there are two returns as follows, > > - > > return retval; > > return 0; > > - > > Here, we remove useless 'return 0;' code. > > > > Signed-off-by: Zhiqiang Liu > > Reviewed-by: Andreas Dilger Thanks, applied. - Ted