Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 2 Apr 2021 16:05:09 -0400
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Andreas Dilger <adilger@whamcloud.com>
Cc:     linux-ext4@vger.kernel.org, Wang Shilong <wshilong@whamcloud.com>
Subject: Re: [PATCH] filefrag: minor usability improvements
Message-ID: <YGd49Qv6GLIKPZ8+@mit.edu>
References: <20210310224715.18467-1-adilger@whamcloud.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210310224715.18467-1-adilger@whamcloud.com>
Precedence: bulk

On Wed, Mar 10, 2021 at 03:47:15PM -0700, Andreas Dilger wrote:
> Add '-V' to filefrag to print the installed version of the tool.
> 
> If '-V' is used twice, print out the list of supported FIEMAP flags.
> This can be used to check if filefrag understands a specific feature.
> 
> Include FIEMAP in the error message printed when filefrag cannot
> get the file layout. Since FIEMAP is commonly available and tried
> first, it should also be mentioned in the error message unless it
> was requested to only run FIBMAP.
> 
> Update filefrag.1.in man page to cover the new -V option.
> 
> Fix a formatting error with the recently added '-P' options, and
> include '-E' and '-P' in the SYNOPSIS section.
> 
> Signed-off-by: Andreas Dilger <adilger@whamcloud.com>
> Lustre-bug-id: https://jira.whamcloud.com/browse/LU-11848
> Reviewed-by: Wang Shilong <wshilong@whamcloud.com>
> Change-Id: Ib126bdd70efa1775aef6db761f54e27a593ebbe5

Applied, thanks.

					- Ted