Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <F552F506-E58D-4705-A2B5-FA2DD8BA2F92@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_EA129647-FA77-45A5-9410-01EC45CE21F2";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH v2] ext4: fix error code in ext4_commit_super
Date:   Sat, 3 Apr 2021 12:34:50 -0600
In-Reply-To: <20210402101631.561-1-changfengnan@vivo.com>
Cc:     "Theodore Y. Ts'o" <tytso@mit.edu>,
        Ext4 Developers List <linux-ext4@vger.kernel.org>
To:     Fengnan Chang <changfengnan@vivo.com>
References: <20210402101631.561-1-changfengnan@vivo.com>
Precedence: bulk


--Apple-Mail=_EA129647-FA77-45A5-9410-01EC45CE21F2
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Apr 2, 2021, at 4:16 AM, Fengnan Chang <changfengnan@vivo.com> wrote:
>=20
> We should set the error code when ext4_commit_super check argument =
failed.
> Found in code review.
> Fixes: c4be0c1dc4cdc ("filesystem freeze: add error handling of =
write_super_lockfs/unlockfs").
>=20
> Signed-off-by: Fengnan Chang <changfengnan@vivo.com>

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> fs/ext4/super.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>=20
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 03373471131c..1130599c87dc 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -5500,8 +5500,10 @@ static int ext4_commit_super(struct super_block =
*sb, int sync)
> 	struct buffer_head *sbh =3D EXT4_SB(sb)->s_sbh;
> 	int error =3D 0;
>=20
> -	if (!sbh || block_device_ejected(sb))
> -		return error;
> +	if (!sbh)
> +		return -EINVAL;
> +	if (block_device_ejected(sb))
> +		return -ENODEV;
>=20
> 	/*
> 	 * If the file system is mounted read-only, don't update the
> --
> 2.29.0
>=20


Cheers, Andreas


--Apple-Mail=_EA129647-FA77-45A5-9410-01EC45CE21F2
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAmBotUsACgkQcqXauRfM
H+Avcw//bzhOUVjNmUXu/k9UovCfRVlnylqXWkaHL1CWaEQ7kbk1wDht0JZamEIX
PHhvkIMVgdMx/ICKtzomDJDYnr2TRT/s6smZ0tOCiixynCCWoFcyQ8BOA5zBf6zz
w5W0bokUeNnAJpWENx4ujvH0X0msg07b10HYLv0h1U0240tBTbOiRhVNJhI3P0EB
Tm+8F2WEA1TBtHp1/weeAl1ENSOAvZFUMKyTIAzIi4paVfO5S8EgYQmqLGAfRM3g
NkWnlUhjdYM2oJZp75Cg0VMGdg5+tEn6wm/pEBBMKPzC8Lb4Y2wDOWTSgKQyOM9/
SRSGqkZ3pqLfA7US4skdCIdtzYFVtBXB1v4M78alN+dmV0oTYSzg3PWKXk2idB7u
geQ2EXdr3YrPvUW79coiaNqFWTxOlSAtDCm21gL3mz8Bk6TwMOnB05hkaOHTccbm
WWa2sO6Gv5jMlpLQKZy/Lq8UihvuAtNSYZ5r6GXGSdSTCVtLsjh0vUJ+itkRe5Ql
lVUpyDql4rAq+Xm3TdFs9/Tz5fSt6DbwIey0sQwOD+l3ufd+h5oHh1f8JseEPlDe
Svx6zGBv8sIyB6YxtyjznB4UiJZ8lvKa1ODXyNLSMgtRIMTu5ivpsJgoWekGbpyk
D5tAd3IECRs6yY9z4yWkMCJUZ4rjAYEzKzHk2/y6XNVqGr93i7o=
=IjHS
-----END PGP SIGNATURE-----

--Apple-Mail=_EA129647-FA77-45A5-9410-01EC45CE21F2--