Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1711561pxf; Fri, 9 Apr 2021 15:46:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8Qw7sgrZRm3dxXOjUXfbb+MwX176iBImB2vj/qotKeIPTHhfc1Xy8EJqP+w+s9w9m6rA8 X-Received: by 2002:aa7:cdcf:: with SMTP id h15mr19492947edw.28.1618008372777; Fri, 09 Apr 2021 15:46:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618008372; cv=none; d=google.com; s=arc-20160816; b=TsyimS3xQMqCDmDHK7OPbhvbOEldXdxPrycDBLQX7LYspvElVQwQGan14sNvvznZhw px8Vkg2QFHu/elHTIQGWdwZj03IWSXLCqQ6zKIQD5U5izFNWa8U5cq70sPmALGaajsfA ObUHidUPq71iX/bwc+yKPy8sDP0PiHgRNwjWs4Z7Za9p5KhUu8JDSLwgy5SNmf3kmIXx a03GuybGw56iFS4v6HLr2cMhIa7PK2flvAiJV8ssKTrcpa7S94TGcaLU9m6zoXjCGHhW m52oxEk96V2YH2qK4Ag5ICGDc6hTxAi7xnMDYTBCFeyMLqUyY4Ji65COcQzc+gakKdx7 LPjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=slmCF8h4z9LUWk7n44i2GkIRhylE0gfb74xbpbezdEA=; b=gQy31RLFgXW/nlzJyNOaJLcV5RZwXS/IQAaDGnYv79Mhyb1Y6rPyDJGL7csaN2qBwq MPgf4PUSX9Xol4e5UhCy0jjTj9zPVxl22XgIhUj45MSdX4JesHifkigq9hKQUPnV20/a rlUD8lWy80MoqRGIvDLLG8vgkuLdrgcddKHKRFCD9oJg9HHxIBe20LVo7rbEeqWx5++d sv8qlXmzJjLH12n0/O1GLVQHx4k2i4i/RG9CGf+wK7Uo2s0PwXTTOKNcyQWrqRI1ZmpQ t5yxxebuFit8pJJ+IZ44y/RYkNgohIykD4NtogtFyvgE4/UM4PbwxD7rXO7SB3a7OFwn ScBg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x22si2764433ejj.667.2021.04.09.15.45.48; Fri, 09 Apr 2021 15:46:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235090AbhDIWpx (ORCPT + 99 others); Fri, 9 Apr 2021 18:45:53 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:57548 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S234880AbhDIWpv (ORCPT ); Fri, 9 Apr 2021 18:45:51 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 139MjYwu030021 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 9 Apr 2021 18:45:34 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 4853C15C3B12; Fri, 9 Apr 2021 18:45:34 -0400 (EDT) Date: Fri, 9 Apr 2021 18:45:34 -0400 From: "Theodore Ts'o" To: Andreas Dilger Cc: Fengnan Chang , Ext4 Developers List Subject: Re: [PATCH v2] ext4: fix error code in ext4_commit_super Message-ID: References: <20210402101631.561-1-changfengnan@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat, Apr 03, 2021 at 12:34:50PM -0600, Andreas Dilger wrote: > On Apr 2, 2021, at 4:16 AM, Fengnan Chang wrote: > > > > We should set the error code when ext4_commit_super check argument failed. > > Found in code review. > > Fixes: c4be0c1dc4cdc ("filesystem freeze: add error handling of write_super_lockfs/unlockfs"). > > > > Signed-off-by: Fengnan Chang > > Reviewed-by: Andreas Dilger Thanks, applied. - Ted