Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp50474pxb; Fri, 9 Apr 2021 17:55:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy3UeREVusu6a3kItFgbTGJG+Y8kNWVr28qLwZaAXDcT7WcvVUZhlopDpMCV08Wv9mkVF8J X-Received: by 2002:a62:f249:0:b029:249:acb4:98b6 with SMTP id y9-20020a62f2490000b0290249acb498b6mr252728pfl.55.1618016151163; Fri, 09 Apr 2021 17:55:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618016151; cv=none; d=google.com; s=arc-20160816; b=Z0QZyHH7SIcHal41Dt5XCRRa3se8RvC2HRCjx/eDKyZxChh2eeS3ztVzIFSkyUOAnv rSHX0CpKtKfY3IcfAu6GHFvBvzjn1/QdNICki3DSP5oWxisRfz9aQOVSfcp+sydpRovc VAGttjS7AS6rfeItg1fnNwG6B6hvaKNhj8OKwfE4cbWDGUTIGdKGcExAFTnv6Cj0g2/H zNnH1qO2MmqgvqWeqZv+VoCrMII/TkK3bmoO9HFMwkf3RBOO29iR+p8F7dEgSvflBrZe q5YH8Fbz/8DB6CVjDGJNuyn53xOOahtm24aCf1vpv4j4egAgv2SlVaWSSRRu47IcZwem MTxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=guCzFoyF8fA8TwnYuXj+EbFTfLFz+eCsA+LNkJT2qH8=; b=teSmcH2tbl74JT6lq30bvsz23jmMo9mcqF9jW6YPgprJEC0It0LuoPDe4u22qGSj4F 44WCFm48BVJRYlFL09y/PDE7dV0S+2DWlSsApoTvyyqzKFYFeL1k5UZj/Es7rUj9zUNA CnDO5mAK+tKWAu9vFeuMYYFYVbdBep2G3L0aBdF4EpS5kM+z8xCuKzPxcbCM7eF5jAkP Yx3PlKWKZHhGLFBc6+UIGbCdXgUyc6eSRCvrzDwSTGtDrgDGTKHyzuPZZ1sARu/hT6L9 vctK5119YNK5j7fFPvCeP847YQCk7IcIzfXmysUjcxNELbLB9QcrnpNF331sUpD8N/FN Fgmw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l7si4429712plg.169.2021.04.09.17.55.30; Fri, 09 Apr 2021 17:55:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235312AbhDJAy5 (ORCPT + 99 others); Fri, 9 Apr 2021 20:54:57 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:43975 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S235268AbhDJAy5 (ORCPT ); Fri, 9 Apr 2021 20:54:57 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 13A0sMod002434 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 9 Apr 2021 20:54:22 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id D15CF15C3B12; Fri, 9 Apr 2021 20:54:21 -0400 (EDT) Date: Fri, 9 Apr 2021 20:54:21 -0400 From: "Theodore Ts'o" To: Ye Bin Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Liu Zhi Qiang , Andreas Dilger Subject: Re: [PATCH v3] ext4: Fix ext4_error_err save negative errno into superblock Message-ID: References: <20210406025331.148343-1-yebin10@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210406025331.148343-1-yebin10@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Apr 06, 2021 at 10:53:31AM +0800, Ye Bin wrote: > As write_mmp_block return 1 when buffer isn't uptodate, return -EIO is > more appropriate. > > Fixes: 54d3adbc29f0 ("ext4: save all error info in save_error_info() and drop ext4_set_errno()") > Reported-by: Liu Zhi Qiang > Signed-off-by: Ye Bin > Reviewed-by: Andreas Dilger Thanks, applied. - Ted