Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp65100pxb; Fri, 9 Apr 2021 18:24:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz0hgforpYnj4uNw2hLb4AMXPTw9ne24m+54Tma2htcR/soaHb0I+3PZQtCeDXmtsdYEI7m X-Received: by 2002:aa7:d60f:: with SMTP id c15mr19820438edr.88.1618017893388; Fri, 09 Apr 2021 18:24:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618017893; cv=none; d=google.com; s=arc-20160816; b=1Iav/DOihSg47AufeQ+ON7uPzgs+n7aRNjb4zYH6Dq2voCgDpSi8foS+aAXiO9ZMIK RbHYkHh77TGGrRtPcJSWMwQYX/Zo3CAvK25yXKx3ztDibILR/bfp48tT+88mMFBhbAYj qzm0rgRWXbDDf1fHkZgWsm8KEe5uF/TR6NOGfaW/nD+k3pJp4MznUHsK0eUYBKY/vWTH SZ+8cYIMmbapCnlrk4NLhyQqOEieiT5f7yQKHF+WumeaIBzg+TJ0tllSh9OhRS1hlohL h9kCnx9217LElabRapVxGIXBpQ9uOtdy97V5bDSRYUiXFZ+2q1HKlzZNuYJ/6b56IR5P 7YqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=rmmyH7QO+4Z/3ZdB2XCVOmBe5w9y8PGQZ3F995OCDXo=; b=NgZogABKekQs2QzP4mbhL+uOt863xT0t0X4lJWSf1XfipKLx6kh5DMKuZCFrg8389+ aQ0g2C1942EBu/uXe3yGpMAP4EzvRPBP5oGizyg0XyHSx6kUuVtZJT5GjLNRCilKh9+8 skXwy1yB7wgNqLVb7EfYljFR/Ksy3JURvyScg1PDNw/RAyffH8bnfRgoAtqDtUpA9IpG r4w2iKI4Y5S70AHpNwQ0cu2RTUtn0o+3Zyt4GC+VrBIMSovMa1+uw5T2g8UjWFMHYwAb sClWO0Hp/H5GQwA8ztEdP1/dlLjRju9m+y01ixpAt9POEz8vRB/lL4pziMP5HnVVZ86a +YLA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r22si3028455edw.235.2021.04.09.18.24.21; Fri, 09 Apr 2021 18:24:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235325AbhDJBY3 (ORCPT + 99 others); Fri, 9 Apr 2021 21:24:29 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:47231 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S235319AbhDJBY3 (ORCPT ); Fri, 9 Apr 2021 21:24:29 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 13A1O9Z2010978 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 9 Apr 2021 21:24:10 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 61BAA15C3B12; Fri, 9 Apr 2021 21:24:09 -0400 (EDT) Date: Fri, 9 Apr 2021 21:24:09 -0400 From: "Theodore Ts'o" To: Jan Kara Cc: linux-ext4@vger.kernel.org, syzbot+30774a6acf6a2cf6d535@syzkaller.appspotmail.com Subject: Re: [PATCH 1/2] ext4: Annotate data race in start_this_handle() Message-ID: References: <20210406161605.2504-1-jack@suse.cz> <20210406161804.20150-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210406161804.20150-1-jack@suse.cz> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Apr 06, 2021 at 06:17:59PM +0200, Jan Kara wrote: > Access to journal->j_running_transaction is not protected by appropriate > lock and thus is racy. We are well aware of that and the code handles > the race properly. Just add a comment and data_race() annotation. > > Reported-by: syzbot+30774a6acf6a2cf6d535@syzkaller.appspotmail.com > Signed-off-by: Jan Kara Thanks, applied. - Ted