Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp66995pxb; Fri, 9 Apr 2021 18:29:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLH84lVzNlFkeiKTe4NVUHZUpn+JjD/2LBAaOa6L/vd67bYJcJ9eHQ80cE4VE69gsZTzSq X-Received: by 2002:a17:907:c16:: with SMTP id ga22mr18211562ejc.120.1618018169360; Fri, 09 Apr 2021 18:29:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618018169; cv=none; d=google.com; s=arc-20160816; b=ERT4lKHDh5dPmkRr/95kSoP/Xpoah7RLwBTAfgxywvrR/JCYLAfVDoIbXozJIoSaMj wLfPKeUaKDCR7A0lPSif3EAFqjYJ8B5LCUyDaz9aRxfO/El9Brk+IQH+0pemUOE+8DBg s3/cyFU89aHs+Xx4+9eKjUHXduIlef5CaJXuKnr7U9dmshjrYt6+pv35dXjQx4eTtAHH TKbU6+gmIzm3478EH6bDcAqPUPDUVvCEoxBEqhnx/V3CTAxeDaJPcKukKJJmgR8qNvIr bLCdyX1N3KkEeRIiLj3fS125b4TLwpXx1IzUdSoBRmyaKS+A1o+ZnRDVQIObUxXMkNsZ egMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=7B8PfWn7tK28YmFObqCq+M1w1U0vbn3yZ9Ho2hNdpXM=; b=vI48WB/P4PQySoV8qg0guQQMBCqDu9Z99Ro5R8yiD/EWmpRUE4lnl19qfoBV7cEHII hakY8ezVYV+X5VP03dRONqY1QY6gzuDVSKSeTlMy1V5IacAqGU1fjxVvTAzp99GvHCHU gdztrCVradIOMzHU+DA56i6WXoTp4kYMkN76T+W13uaXNVtprnOIFGg8ebHvVLaPkMzv 21qGHgJVrLIIyU8UC4mV8FL0GllJVjS8BfNQPUo0PK0RYA8JIbAkKDXe0eaYFmfK5O5z xD1O0Uxi83IKxGaKSk3jVi/F9gNLJvAlDM9cXZKE/SSF4TPTpxH+g/dCCTmX7XdOjlR1 NU0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r22si3028455edw.235.2021.04.09.18.29.05; Fri, 09 Apr 2021 18:29:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235207AbhDJB3S (ORCPT + 99 others); Fri, 9 Apr 2021 21:29:18 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:47732 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S235201AbhDJB3R (ORCPT ); Fri, 9 Apr 2021 21:29:17 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 13A1Sk5p011989 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 9 Apr 2021 21:28:46 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 1287E15C3B12; Fri, 9 Apr 2021 21:28:46 -0400 (EDT) Date: Fri, 9 Apr 2021 21:28:46 -0400 From: "Theodore Ts'o" To: Xu Yihang Cc: adilger.kernel@dilger.ca, harshadshirwadkar@gmail.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] ext4: fix error return code in ext4_fc_perform_commit() Message-ID: References: <20210408070033.123047-1-xuyihang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210408070033.123047-1-xuyihang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Apr 08, 2021 at 03:00:33PM +0800, Xu Yihang wrote: > In case of if not ext4_fc_add_tlv branch, an error return code is missing. > > Fixes: aa75f4d3daae ("ext4: main fast-commit commit path") > Reported-by: Hulk Robot > Signed-off-by: Xu Yihang Thanks, applied. - Ted