Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 14 Apr 2021 07:50:45 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Nico Pache <npache@redhat.com>
Cc:     linux-kernel@vger.kernel.org, brendanhiggins@google.com,
        linux-ext4@vger.kernel.org, netdev@vger.kernel.org,
        rafael@kernel.org, linux-m68k@lists.linux-m68k.org,
        geert@linux-m68k.org
Subject: Re: [PATCH 1/2] kunit: Fix formatting of KUNIT tests to meet the
 standard
Message-ID: <YHaCtfn2UqKbhB3a@kroah.com>
References: <20210414043303.1072552-1-npache@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210414043303.1072552-1-npache@redhat.com>
Precedence: bulk

On Wed, Apr 14, 2021 at 12:33:02AM -0400, Nico Pache wrote:
> There are few instances of KUNIT tests that are not properly defined.
> This commit focuses on correcting these issues to match the standard
> defined in the Documentation.
> 
>     Issues Fixed:
>  - Tests should default to KUNIT_ALL_TESTS
>  - Tests configs tristate should have `if !KUNIT_ALL_TESTS`
>  - Tests should end in KUNIT_TEST, some fixes have been applied to
>     correct issues were KUNIT_TESTS is used or KUNIT is not mentioned.
> 
> No functional changes other than CONFIG name changes
> Signed-off-by: Nico Pache <npache@redhat.com>

Please put a blank line before your signed-off-by, as is required by the
tools :(

thanks,

greg k-h