Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp809122pxy; Thu, 22 Apr 2021 14:04:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzXHjvN7DvCT3YVZkkf01gyY7JtgOgwFhpnI5lhR57gZLwzHvSxaoUlnzHwSeeD537U9KF X-Received: by 2002:a17:906:98c1:: with SMTP id zd1mr605703ejb.447.1619125454818; Thu, 22 Apr 2021 14:04:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619125454; cv=none; d=google.com; s=arc-20160816; b=Vyrqa9xTbqUuOYwMAmR2zSCFp0OP8QD/QRGKPyVfWRYFkrEQV0+z1Plz++qRyZ2yx2 qnCRoO0SMYcoQqe5h0g+YgCPQh80vRiYIGxx6xoYKgBdR+M+DGQsGOcxiaEH++grjLjR VGgoxsog+J3B/Ny3H7NG69oy39ZRFd1n0IY4yNLu609SJqxjUAOg+B+M1+DElOpY2i3m SVE2QI85WmMKwSdtL0Ud39yf5KDX2C9uFGavGHl9lE4fh0YsbVhlW7zVjuGxG4o1BojR xrEwaKhJAuR/xp9NBqfIq1F68K16z0lxKkg6wikuw5FRrZebuuNepDqftTyJamdZNCOW W19A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=bxz+icuwInivQfLE0GRK8kPha67Tzmw3WmYvt9UL7Gs=; b=OI0OaFo1o0eeNrC9fxTfMYqwu35ygaV7QSCunzXlYij2EG7tHeodSPtchEVYMGzExj x1NvFxz4zUq5SmpoTnqeSzS+OtJ5poCAmHXvutpqNX3Fa1ALYBGMW5LLrmlYkzukFzZS 2Tuywezn7lntUPqU1lfUJv82vN2JOwTMUzFct3K1lojeeBiL3yTksaw+uWYJAg+pbTCw Hh/wbk2n/UMNx39GIweluB06MSZxhul5jE7Z+ffUVcfoZsC8Gtfl65Dk5sVlP8LycDvp b2jhVttedFZpsw1fGWn8t6heGcc2xp6fdZxT9hChQZp1alCgxP/4QpuIYx43sBoZXkwi s0ow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f13si3303650ejl.560.2021.04.22.14.03.46; Thu, 22 Apr 2021 14:04:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236877AbhDVVEG (ORCPT + 99 others); Thu, 22 Apr 2021 17:04:06 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:54147 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S239483AbhDVVEG (ORCPT ); Thu, 22 Apr 2021 17:04:06 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 13ML3RKB011390 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Apr 2021 17:03:27 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id EF48815C3B0D; Thu, 22 Apr 2021 17:03:26 -0400 (EDT) Date: Thu, 22 Apr 2021 17:03:26 -0400 From: "Theodore Ts'o" To: Leah Rumancik Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH v4] ext4: wipe ext4_dir_entry2 upon file deletion Message-ID: References: <20210422180834.2242353-1-leah.rumancik@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210422180834.2242353-1-leah.rumancik@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Apr 22, 2021 at 06:08:34PM +0000, Leah Rumancik wrote: > Upon file deletion, zero out all fields in ext4_dir_entry2 besides rec_len. > In case sensitive data is stored in filenames, this ensures no potentially > sensitive data is left in the directory entry upon deletion. Also, wipe > these fields upon moving a directory entry during the conversion to an > htree and when splitting htree nodes. > > The data wiped may still exist in the journal, but there are future > commits planned to address this. > > Signed-off-by: Leah Rumancik Applied, thanks. - Ted