Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From:   Andreas Dilger <adilger@dilger.ca>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH v5] e2image: add option to ignore fs errors
Date:   Fri, 23 Apr 2021 10:25:18 -0600
Message-Id: <4972D70F-1765-413B-971B-CE4147993B29@dilger.ca>
References: <20210422041347.29039-1-artem.blagodarenko@gmail.com>
Cc:     linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca,
        Alexey Lyashkov <alexey.lyashkov@hpe.com>,
        Artem Blagodarenko <artem.blagodarenko@hpe.com>
In-Reply-To: <20210422041347.29039-1-artem.blagodarenko@gmail.com>
To:     Artem Blagodarenko <artem.blagodarenko@gmail.com>
Precedence: bulk

On Apr 23, 2021, at 07:30, Artem Blagodarenko <artem.blagodarenko@gmail.com>=
 wrote:
>=20
> =EF=BB=BFAdd extended "-E ignore_error" option to be more tolerant
> to fs errors while scanning inode extents.

Not to be pedantic, but should this allow "ignore_errors", since it will
presumably ignore more than one error.  If already using "ignore_error"
in the field you could accept both for some time until able to change over,
as we've done with "ea_inode" vs. "large_xattr" in the Lustre e2fsprogs
for years.=20

> Changes since preveious version:
> - rebased on top of the master

This should go after the "---" so that it isn't in the final commit message.=
=20

> Signed-off-by: Alexey Lyashkov <alexey.lyashkov@hpe.com>
> Signed-off-by: Artem Blagodarenko <artem.blagodarenko@hpe.com>
> Cray-bug-id: LUS-1922
> Change-Id: Ib79300656726839b1d3b7ee1dd0793c60679d296
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>
> ---

One typo in the man page below:

> diff --git a/misc/e2image.8.in b/misc/e2image.8.in
> index cb176f5d..45a06d3b 100644
> --- a/misc/e2image.8.in
> +++ b/misc/e2image.8.in
> @@ -137,6 +144,16 @@ useful if the file system is being cloned to a flash-=
based storage device
> (where reads are very fast and where it is desirable to avoid unnecessary
> writes to reduce write wear on the device).
> .TP
> +.BI \-E " extended_options"
> +Set e2iamge extended options.

"e2image"

Ted could fix this in the final commit
Cheers, Andreas

>  Extended options are comma separated, and
> +may take an argument using the equals ('=3D') sign.  The following option=
s
> +are supported:
> +.RS 1.2i
> +.TP
> +.BI ignore_error
> +Grab an image from a corrupted FS and ignore fs errors.
> +.RE
> +.TP
> .B \-f
> Override the read-only requirement for the source filesystem when saving
> the image file using the