Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ext4: remove redundant check buffer_uptodate()
To:     riteshh <riteshh@linux.ibm.com>,
        Joseph Qi <joseph.qi@linux.alibaba.com>
Cc:     tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org
References: <1619407399-72280-1-git-send-email-joseph.qi@linux.alibaba.com>
 <20210426050545.m3fbtlwdf32lgqvu@riteshh-domain>
From:   Joseph Qi <jiangqi903@gmail.com>
Message-ID: <4314943d-b39b-3f00-2b60-41756e6675f3@gmail.com>
Date:   Mon, 26 Apr 2021 14:15:44 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <20210426050545.m3fbtlwdf32lgqvu@riteshh-domain>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 4/26/21 1:05 PM, riteshh wrote:
> On 21/04/26 11:23AM, Joseph Qi wrote:
>> Now set_buffer_uptodate() will test first and then set, so we don't have
>> to check buffer_uptodate() first, remove it to simplify code.
> 
> Maybe we can change below function as well then.
> No need to check same thing twice since set_buffer_uptodate() is already doing
> the check.
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index b258e8279266..856bd9981409 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -3749,7 +3749,7 @@ static inline int ext4_buffer_uptodate(struct buffer_head *bh)
>          * have to read the block because we may read the old data
>          * successfully.
>          */
> -       if (!buffer_uptodate(bh) && buffer_write_io_error(bh))
> +       if (buffer_write_io_error(bh))
>                 set_buffer_uptodate(bh);
>         return buffer_uptodate(bh);
>  }
> 
> With that pls feel free to add:
> Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>
> 

Sure, will send v2 with above addressed.

Thanks,
Joseph