Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp4239715pxy; Mon, 26 Apr 2021 23:30:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJylsil/ZKuqZT88wAj5MlEbJdh4d++g+wdzEESSK8uw5ok7ZiZDEwB+cumZzIgZX2M2plF7 X-Received: by 2002:aa7:8097:0:b029:229:83ec:cac0 with SMTP id v23-20020aa780970000b029022983eccac0mr21322453pff.67.1619505012210; Mon, 26 Apr 2021 23:30:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619505012; cv=none; d=google.com; s=arc-20160816; b=ezmCyphlq3j6b5th0NT9aa9dMme3A9DAKmc+0lUpm8i2RGMU2i/00OOt3Jfsga8KOu bTeoKtz/VHq2y30x9oo8kUTinqaQAns7aJ1/j6NlO+Wc9rXfZK+lzDu7One2XyzwBEYt XOqxwLe9eDmpRSU8eBAEP08mHVSIrvuyuTdR3gbMlznMKXYN594P9wBQdWUzzGoBXpt/ G6ImSAEgZq7qOsX+cuWI4+L1943NZwoWf/szBOGUy4PaiSjO9xiru1mNm1txP+LSc+YI Bt0beksUkuGmFEwMM7bb6lhm13YbRiOdhIW8gqZU6GLnmXIhxTOSO8wpG8RDWk1/NCPm itbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=r/PKhDSOpuWVr+iFptHfckso/hHr0MElpssnEZU9ivc=; b=TUWmTRgXZbNcbhoZQzRmpTz8vW2oJoKXNr0ujmM2/1d8FcthQ1zt1DBcxWoPi8DXRU wdv+uObK1dRnIksYYhyiOgiQ9wTbMOAgB90qNMAomxY8X4cfYwclJoL5iMRCpbYHzLcS fhGUJVKqIIXHUnU5DB5mIOpRYcQ6nojdT7hlBrfFk28OlmIN2qk+FCFr743TGGS4vf2j Tbi7P7KDH6aLz8aGVpXpZPkZuM1+Y+Sc1PK00KF5Ob4XQQq80qsoZqcXVznGDCEgweQ9 YM2jmWEdqkYtD+hk4yPNKKabKKco5jbP57bb/dv1xGI0+hcn9xgdBbEKc+fTZUuhVSqH xqOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=t9mh6FBu; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u1si20501671pgr.162.2021.04.26.23.29.56; Mon, 26 Apr 2021 23:30:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=t9mh6FBu; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231468AbhD0Gah (ORCPT + 99 others); Tue, 27 Apr 2021 02:30:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229578AbhD0Gah (ORCPT ); Tue, 27 Apr 2021 02:30:37 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2E88C061574; Mon, 26 Apr 2021 23:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=r/PKhDSOpuWVr+iFptHfckso/hHr0MElpssnEZU9ivc=; b=t9mh6FBuC9Q6m6Enq+ly4WxESH mT9pTb/kWbZcUPQ/2+eQFn4c3qeB+Uacs9KFcE/oh+/JwyoYXcZvkoaxwwT7pieJlc35Qe1JIbm6r ZOGJAr21vCmO7XF/wZXQAEuEpS7JVCSOWlWyK2YKeFvrI65uv0DV7Q7soPVHJ3RS7RSRr4dWwTA60 pPffe0QyygoYiTTiltxuCTKdm1XUCP8UaZm3fdB0oXG6/32cJMkIT9eYHRIbWYmInYJXXBGDo7OZT w4bTgXAYjwnJAVam9HyTeanfOzo4t1YlNvSLe6ACMjwSPdPnHSwL+aY1POS5JqZR2WFT1gZcb2FwG I8/7E5ww==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lbHDX-006ZEG-GN; Tue, 27 Apr 2021 06:29:12 +0000 Date: Tue, 27 Apr 2021 07:29:07 +0100 From: Christoph Hellwig To: Shreeya Patel Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org, chao@kernel.org, krisman@collabora.com, ebiggers@google.com, drosen@google.com, ebiggers@kernel.org, yuchao0@huawei.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, kernel@collabora.com, andre.almeida@collabora.com Subject: Re: [PATCH v8 4/4] fs: unicode: Add utf8 module and a unicode layer Message-ID: <20210427062907.GA1564326@infradead.org> References: <20210423205136.1015456-1-shreeya.patel@collabora.com> <20210423205136.1015456-5-shreeya.patel@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210423205136.1015456-5-shreeya.patel@collabora.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat, Apr 24, 2021 at 02:21:36AM +0530, Shreeya Patel wrote: > utf8data.h_shipped has a large database table which is an auto-generated > decodification trie for the unicode normalization functions. > We can avoid carrying this large table in the kernel unless it is required > by the filesystem during boot process. > > Hence, make UTF-8 encoding loadable by converting it into a module and > also add built-in UTF-8 support option for compiling it into the > kernel whenever required by the filesystem. The way this is implemement looks rather awkward. Given that the large memory usage is for a data table and not for code, why not treat is as a firmware blob and load it using request_firmware?