Received: by 2002:a05:6a10:a852:0:0:0:0 with SMTP id d18csp1348027pxy; Sat, 1 May 2021 10:45:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQGXepAiCzdbuEbtxfReHzUOufWrJyCLu2E6VmB6FpchUW04lDSR88L99ffGYH22oKYHJ2 X-Received: by 2002:aa7:83d8:0:b029:249:79c9:fd49 with SMTP id j24-20020aa783d80000b029024979c9fd49mr10966233pfn.72.1619891158687; Sat, 01 May 2021 10:45:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619891158; cv=none; d=google.com; s=arc-20160816; b=ngGyPjPcIaDYJzRS+70FJfQrGNDL8qCEj9Icipr2uRuQUjTKbaHnzI/gnSsUqAf22u eSSy6oAaGUvqKXdAE6pBU0Y8Sqb/3mS9jX6PMTLpGkUra4YJrwtKEpquiCSQ1AcJPkA6 YQOrEMlrF2ApvbQKBMmk26Ogitr5v8MyJMhtvdmp+Va6TQgtUqjRNAfmRAOpiHbrtRpk a1F/5BLxlxWDsBwUongIKW4CHhpfqLHeal+vzgdCSc/UZ3uqkp5kS19Ra1EE+qFN7ahU 3Ugpr0wb5D2lxb2+lZwylMF9XSFyNDoXfUFxNrDWkDLbxbK5K5JLvzyarFGQuhQHlb2B QkbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:in-reply-to:cc:references:message-id:date :subject:mime-version:from:content-transfer-encoding:dkim-signature; bh=bteLvbdWFmjpY8EDbu1U3LFocxkdcdaEmOWgbjbb3e4=; b=g/VOzHO+1RpBIAXytgsSVbVxbdrmy1V6ggj3OEOA7zUsehgeuvntbcU0aP5G1VQulA m2AYS1jv2HhcUjFmAmmyTbAeqO6ar9IjHC+UZu//LY+IcpeVU/oKS0uxhbc6SQoDAVPf tOUC6lah9UV/RCmxhxvyIxFf6DLD6zFevUb7OlB/iXacQcUmklAl7J5yhTNOurjC/WS/ uxmZUSOU9lR3Duxps4neT1Zla6cg/zOzUYLxn7DARd70c/PVnmisT5F9liuhWp59fGEO QTO9FEsT/qJg5SJZcl8+QExAeUA9d6gwC8rneLEZ12vfT/aeL1AW99u7GvnKee6fm6DA M+Hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@dilger-ca.20150623.gappssmtp.com header.s=20150623 header.b=Xj78uBm4; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n127si7896568pga.11.2021.05.01.10.45.33; Sat, 01 May 2021 10:45:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@dilger-ca.20150623.gappssmtp.com header.s=20150623 header.b=Xj78uBm4; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230522AbhEARow (ORCPT + 99 others); Sat, 1 May 2021 13:44:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230450AbhEARow (ORCPT ); Sat, 1 May 2021 13:44:52 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D805C06138B for ; Sat, 1 May 2021 10:44:01 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id p12so771554pgj.10 for ; Sat, 01 May 2021 10:44:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dilger-ca.20150623.gappssmtp.com; s=20150623; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=bteLvbdWFmjpY8EDbu1U3LFocxkdcdaEmOWgbjbb3e4=; b=Xj78uBm4c4NnxCJZlxp4GtzrG1pmHY8B3wWUNaFXF2RmfVL9vrSMFfeSWynGMRb/zu 95e/M6La/Ry/riBEMcLqGBrR7HAukcwSj10QDUJc8wt0pgZg6ARJh2AffHUmAUKlcV/+ 22uQERRAnSlVX/2guVplhffT0OvmD4KXY75SgMGTbBvLziDCaf9RlDMD0h4xfHeaGFA1 vG6NVia+DlMUZ/VWv3VJGC9lHWp53KnqA0Uqw9AUEW47C2YiTo+pVevpkKDY4VIRlrSP KI0AjVtYlQk6jt+jaDstc0Q7ftcbWvR2nyUo7UKPLznlCM6O/d548oVlZbhqUxpB9xnh 0+jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=bteLvbdWFmjpY8EDbu1U3LFocxkdcdaEmOWgbjbb3e4=; b=Xj+QSn/pIMKOsPBPnroMAuo6iXz0gBWYhIWtsclwLL5s0rj1SyCuKukXN+LWWybERm /veu8EJarPnn5XZtmHqykcm5bPIXqjAf2Ukkeei5PFLAOBhu3wZI4CTDHMYcUw1EDugH 6Z2DRR5PYyAC3F84yif7iWWN4nn2zudM5Rjj2xmJRbbkN5JC8Evq8f2HURTb9L9xiXnp 9zn8MhKPRG3ad5bKblq+9VgHIBG0FY5su7az4wHz1AR7tmZoFlbnTLio4XCfEMoUUCkH nwGClJar37hh0y/d9yZ5aH1GLe3Er7KtqimJgumoHtDlo5BOM6X1wwRdsiRfoZTaNF6W Vuug== X-Gm-Message-State: AOAM530rpghEv78eJheDaebDX1n5oee0Kz2hTf5ydECVL8N/iAhcaAT4 rW19laIgG4KNBAMlutpoWPOf2A== X-Received: by 2002:a62:3706:0:b029:211:3d70:a55a with SMTP id e6-20020a6237060000b02902113d70a55amr10297092pfa.16.1619891041184; Sat, 01 May 2021 10:44:01 -0700 (PDT) Received: from [192.168.10.175] (S01061cabc081bf83.cg.shawcable.net. [70.77.221.9]) by smtp.gmail.com with ESMTPSA id s32sm4998479pfw.2.2021.05.01.10.43.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 May 2021 10:44:00 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Andreas Dilger Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] fs: ext4: mballoc: amend goto to cleanup groupinfo memory correctly Date: Sat, 1 May 2021 10:43:57 -0700 Message-Id: <6E6AEEB4-1FBA-40F1-8328-8E304E68A7C6@dilger.ca> References: Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: To: Phillip Potter , tytso@mit.edu X-Mailer: iPhone Mail (18D70) Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On May 1, 2021, at 02:18, Phillip Potter wrote: >=20 > =EF=BB=BFHi All, >=20 > Sorry to be pushy (I know everyone is busy) but I've had no feedback on > this patch yet: > https://lore.kernel.org/linux-ext4/20210412073837.1686-1-phil@philpotter.c= o.uk/T/#u >=20 > Could I please ask for it to be reviewed? Many thanks. Hi Phil, I've looked at the patch and it looks good. You can add my: Reviewed-by: Andreas Dilger Note in the future that it is a bit easier to review (IMHO) if you include t= he original patch in your ping email, but not a big deal.=20 Cheers, Andreas=