Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 4 May 2021 11:18:51 -0400
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Andreas Dilger <adilger@dilger.ca>
Cc:     Ext4 Developers List <linux-ext4@vger.kernel.org>,
        harshads@google.com
Subject: Re: [PATCH] e2fsck: fix portability problems caused by unaligned
 accesses
Message-ID: <YJFl2ydURsg3Ec/c@mit.edu>
References: <20210504031024.3888676-1-tytso@mit.edu>
 <8E9C71E8-FE5F-4CB8-BA62-8D8895DCA92A@dilger.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8E9C71E8-FE5F-4CB8-BA62-8D8895DCA92A@dilger.ca>
Precedence: bulk

On Tue, May 04, 2021 at 12:29:21AM -0600, Andreas Dilger wrote:
> > @@ -344,10 +361,10 @@ static int ext4_fc_replay_scan(journal_t *j, struct buffer_head *bh,
> > 						offsetof(struct ext4_fc_tail,
> > 						fc_crc));
> > 			jbd_debug(1, "tail tid %d, expected %d\n",
> > -					le32_to_cpu(tail->fc_tid),
> > +					get_le32(&tail->fc_tid),
> > 					expected_tid);
> > -			if (le32_to_cpu(tail->fc_tid) == expected_tid &&
> > -				le32_to_cpu(tail->fc_crc) == state->fc_crc) {
> > +			if (get_le32(&tail->fc_tid) == expected_tid &&
> > +				get_le32(&tail->fc_crc) == state->fc_crc) {
> 
> (style) better to align continued line after '(' on previous line?  That way
> it can be distinguished from the next (body) line more easily

Thanks, I fixed up the whitespace style issues (which were in the
original code, but while we're modifying these lines, might as well
fix them up).

					- Ted