Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp591491pxj; Fri, 7 May 2021 15:50:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz8EnhyMDixVSF1WbqOq2cqFTC8PtKahVnUSXHOlFaIczbt/pt5ZWandg+4FXLtpGzAah1U X-Received: by 2002:a17:90a:c7c8:: with SMTP id gf8mr25843037pjb.113.1620427845794; Fri, 07 May 2021 15:50:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620427845; cv=none; d=google.com; s=arc-20160816; b=UWr8Zo6ntt0XXMVcDmHyrGw4FMfzGG0CoODLauQWUHJv54I17X+i3+T2/3wQWZtAeH Zy6747W9b9FR1EdRBjDS7o0h8szPKM7GIGDvHklaWXLrcsPXClZH79fLaEzGJvBFpoRm 7hB6oP3FrI4aJ1AaCSqG2r6M/BbNq/w+KoNxGfXwNx7oZLYutMVMJELjjTY2yfS46u+w uVBzr37rdTSE3qcem4scDBpP6Jz3u0wKO+gB3lZF5aQ/iO7mPB81P+jJRle0hP88G9T5 UoXQSjsVDLnIfrSOqXQOccQiKoS+6uhUOS7IvFEl1MeyvDi2dWGeNCDEiyEzSmJiRvVh doAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=h6JcY/DKalIEgr3UCmsxLw+3o5xOtysPzCU44q25GmI=; b=DrTYKqf3mPj5kIBMrlLiy2xvZSLzn65SW3/6RWnsQFX6VWdbR2/mlikFk/ZaL+7uR6 3XlGz/aVptEzreD84ykrKHgQ6jdT42vMprotfJvMZKawlQ/xBOve9wmALNbpJ297W4hl kgVpdqZ2oMRtSE9XmFQ4whSsxeyzbJZt9xBCZz3nk+vw8T0AsHi011TBQ9ANYJ4hEW4I MvrRvKf6qmPs2mUNlX9K4QiaodG1iFzrkPqamycFmlHJoSGRlY3MvIsSn6vGARR0vY9b +qfV4FeEDVaEqL1QQGWbWZD4DuRVSg7zJW+BsvFlVYULAeS44+xG/JJhBobuxiWRPzr6 /Gzg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q17si9891776pgd.438.2021.05.07.15.50.25; Fri, 07 May 2021 15:50:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229488AbhEGWvC (ORCPT + 99 others); Fri, 7 May 2021 18:51:02 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:40293 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229470AbhEGWvB (ORCPT ); Fri, 7 May 2021 18:51:01 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 147Mntd2018763 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 7 May 2021 18:49:55 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id F414015C39BD; Fri, 7 May 2021 18:49:54 -0400 (EDT) Date: Fri, 7 May 2021 18:49:54 -0400 From: "Theodore Ts'o" To: Artem Blagodarenko Cc: linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca, Alexey Lyashkov , Artem Blagodarenko Subject: Re: [PATCH] e2image: fix overflow in l2 table processing Message-ID: References: <20210422052448.29802-1-artem.blagodarenko@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210422052448.29802-1-artem.blagodarenko@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Apr 22, 2021 at 01:24:48AM -0400, Artem Blagodarenko wrote: > For a large partition during e2image capture process > it is possible to overflow offset at multiply operation. > This leads to the situation when data is written to the > position at the start of the image instead of the image end. > > Let's use the right cast to avoid integer overflow. > > Signed-off-by: Alexey Lyashkov > Signed-off-by: Artem Blagodarenko > HPE-bug-id: LUS-9368 Thanks, applied. - Ted