Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.20\))
Subject: Re: [PATCH v5] e2image: add option to ignore fs errors
From:   =?utf-8?B?0JHQu9Cw0LPQvtC00LDRgNC10L3QutC+INCQ0YDRgtGR0Lw=?= 
        <artem.blagodarenko@gmail.com>
In-Reply-To: <4972D70F-1765-413B-971B-CE4147993B29@dilger.ca>
Date:   Thu, 20 May 2021 12:25:10 +0300
Cc:     linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca,
        Alexey Lyashkov <alexey.lyashkov@hpe.com>,
        Artem Blagodarenko <artem.blagodarenko@hpe.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <2177370F-B771-49A7-B59B-2820B73499CC@gmail.com>
References: <20210422041347.29039-1-artem.blagodarenko@gmail.com>
 <4972D70F-1765-413B-971B-CE4147993B29@dilger.ca>
To:     Andreas Dilger <adilger@dilger.ca>
Precedence: bulk

Hello.

Andreas, thank you for the review.=20
It looks like remarks don=E2=80=99t require v6 and can be fixed during a =
merge.

Does anybody has other any objections/ideas?

Thanks.
Artem Blagodarenko.

> On 23 Apr 2021, at 19:25, Andreas Dilger <adilger@dilger.ca> wrote:
>=20
> On Apr 23, 2021, at 07:30, Artem Blagodarenko =
<artem.blagodarenko@gmail.com> wrote:
>>=20
>> =EF=BB=BFAdd extended "-E ignore_error" option to be more tolerant
>> to fs errors while scanning inode extents.
>=20
> Not to be pedantic, but should this allow "ignore_errors", since it =
will
> presumably ignore more than one error.  If already using =
"ignore_error"
> in the field you could accept both for some time until able to change =
over,
> as we've done with "ea_inode" vs. "large_xattr" in the Lustre =
e2fsprogs
> for years.=20
>=20
>> Changes since preveious version:
>> - rebased on top of the master
>=20
> This should go after the "---" so that it isn't in the final commit =
message.=20
>=20
>> Signed-off-by: Alexey Lyashkov <alexey.lyashkov@hpe.com>
>> Signed-off-by: Artem Blagodarenko <artem.blagodarenko@hpe.com>
>> Cray-bug-id: LUS-1922
>> Change-Id: Ib79300656726839b1d3b7ee1dd0793c60679d296
>> Reviewed-by: Andreas Dilger <adilger@dilger.ca>
>> ---
>=20
> One typo in the man page below:
>=20
>> diff --git a/misc/e2image.8.in b/misc/e2image.8.in
>> index cb176f5d..45a06d3b 100644
>> --- a/misc/e2image.8.in
>> +++ b/misc/e2image.8.in
>> @@ -137,6 +144,16 @@ useful if the file system is being cloned to a =
flash-based storage device
>> (where reads are very fast and where it is desirable to avoid =
unnecessary
>> writes to reduce write wear on the device).
>> .TP
>> +.BI \-E " extended_options"
>> +Set e2iamge extended options.
>=20
> "e2image"
>=20
> Ted could fix this in the final commit
> Cheers, Andreas
>=20
>> Extended options are comma separated, and
>> +may take an argument using the equals ('=3D') sign.  The following =
options
>> +are supported:
>> +.RS 1.2i
>> +.TP
>> +.BI ignore_error
>> +Grab an image from a corrupted FS and ignore fs errors.
>> +.RE
>> +.TP
>> .B \-f
>> Override the read-only requirement for the source filesystem when =
saving
>> the image file using the