Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 May 2021 08:19:26 +0530
From:   riteshh <riteshh@linux.ibm.com>
To:     chenyichong <chenyichong@uniontech.com>
Cc:     tytso@mit.edu, adilger.kernel@dilger.ca,
        linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] use local variables ei instead of invoking function
 EXT4_I
Message-ID: <20210527024926.oqfxngkm4phgrim4@riteshh-domain>
References: <20210526052930.11278-1-chenyichong@uniontech.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210526052930.11278-1-chenyichong@uniontech.com>
Precedence: bulk

On 21/05/26 01:29PM, chenyichong wrote:

Thanks for the patch. Looks good to me.
Feel free to add

Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>


> Signed-off-by: chenyichong <chenyichong@uniontech.com>
> ---
>  fs/ext4/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index fe6045a46599..a5c4cd1c757b 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -374,7 +374,7 @@ void ext4_da_update_reserve_space(struct inode *inode,
>  	ei->i_reserved_data_blocks -= used;
>  	percpu_counter_sub(&sbi->s_dirtyclusters_counter, used);
>
> -	spin_unlock(&EXT4_I(inode)->i_block_reservation_lock);
> +	spin_unlock(&ei->i_block_reservation_lock);
>
>  	/* Update quota subsystem for data blocks */
>  	if (quota_claim)
> --
> 2.20.1
>
>
>