Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <9C696275-1834-4CCE-BAC1-A63835FE5F53@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_B9A69006-4295-4061-8F41-5647465943A5";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH V2 3/7] ext4: remove the repeated comment of
 ext4_trim_all_free
Date:   Thu, 27 May 2021 13:49:33 -0600
In-Reply-To: <aeaa8757-b0f9-7e3e-278c-c8de77c1b6fc@gmail.com>
Cc:     Theodore Ts'o <tytso@mit.edu>,
        Ext4 Developers List <linux-ext4@vger.kernel.org>,
        lishujin@kuaishou.com,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>
To:     Wang Jianchao <jianchao.wan9@gmail.com>
References: <164ffa3b-c4d5-6967-feba-b972995a6dfb@gmail.com>
 <a602a6ba-2073-8384-4c8f-d669ee25c065@gmail.com>
 <49382052-6238-f1fb-40d1-b6b801b39ff7@gmail.com>
 <aeaa8757-b0f9-7e3e-278c-c8de77c1b6fc@gmail.com>
Precedence: bulk


--Apple-Mail=_B9A69006-4295-4061-8F41-5647465943A5
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On May 26, 2021, at 2:43 AM, Wang Jianchao <jianchao.wan9@gmail.com> =
wrote:
>=20
> Signed-off-by: Wang Jianchao <wangjianchao@kuaishou.com>

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> fs/ext4/mballoc.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>=20
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index f984f15..85418cf 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -5741,15 +5741,10 @@ static int ext4_try_to_trim_range(struct =
super_block *sb,
>  * @max:		last group block to examine
>  * @minblocks:		minimum extent block count
>  *
> - * ext4_trim_all_free walks through group's buddy bitmap searching =
for free
> - * extents. When the free block is found, ext4_trim_extent is called =
to TRIM
> - * the extent.
> - *
> - *
>  * ext4_trim_all_free walks through group's block bitmap searching for =
free
>  * extents. When the free extent is found, mark it as used in group =
buddy
>  * bitmap. Then issue a TRIM command on this extent and free the =
extent in
> - * the group buddy bitmap. This is done until whole group is scanned.
> + * the group buddy bitmap.
>  */
> static ext4_grpblk_t
> ext4_trim_all_free(struct super_block *sb, ext4_group_t group,
> --
> 1.8.3.1


Cheers, Andreas


--Apple-Mail=_B9A69006-4295-4061-8F41-5647465943A5
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAmCv980ACgkQcqXauRfM
H+D1SQ//Tey6D1xM4AoyRkbSV3CNBSGp/s0htiPyL3K7jV7W+zcOvlDiTp+RXEuS
QA1c5KDV3jmFccFwJ0AtZUWLRj5PdU65pppq4Jhuesd0JufGbKaXHJB51u3IUM0j
W0G2dvwWQJYDR/qkygqT1924Lw54gQEabcvqMVySVyxorOqtWoafrarXqJRy/u4+
gTbasiRSQ5+++lx2V9je8FqVmZASwDNMJfJQa4TBylS9Ye3eyCrxZmlUZoT+lm8E
QHeFAveWjsXs4m2y+OnrgCUXYKJe/evcC6xXx+s01uqoKZYeyJmK/pDdGXygBljt
YaXBGyQu5O8ltSqF6YwqKvTVx6/bhV42pYsf4ftr5ZpFN2NpOtoQxHxyVPn5XTtD
meplvoayXWA+kQh4EvCjkswKQVD9z2XkcpcGXGZUJHL7hJdNEgvNa5WSVPgYOILn
oqcIo4xiPKG+EsayM8XAzEaUip0IgkxPYk9s9A3wrZM6dRxC7FhQyrY4i8c1XF9m
QDn4xMqJc60n+nNf5UDxuo3zs2OHWAXapJqGZxMRPSfgyfCLtYPUnF6eWVPdp+Dx
ey8NYsmLKtw4ptH3jb7cMyeX1CnAcFn7jq4bT6N4aoIZWOkOsssXrfcoih0gsngu
6GWRsuDevnNXgiggNa2dqO4T5boM6WWfoeCtm8Ir5fTq4bZVbyw=
=4Vnz
-----END PGP SIGNATURE-----

--Apple-Mail=_B9A69006-4295-4061-8F41-5647465943A5--