Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2421331pxj; Mon, 31 May 2021 01:32:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/RxUZr1n9CnbJ0Nx2sJzdSzOWX/xRpAFFqKZrwhE667IK+rltWg6Ai2yPzLQbGqwYBS+H X-Received: by 2002:a17:907:628d:: with SMTP id nd13mr21224680ejc.299.1622449919894; Mon, 31 May 2021 01:31:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622449919; cv=none; d=google.com; s=arc-20160816; b=Hlli+SKR7Dtk2Bb05zANiBN26q02lwXlqptn+i1FNgJN0CCD5H1KXCRMG35bOkJH9Y ySH9IqyA4+Jyeq7Ut0pTdTSS8BOurJo1g0CV0vT48tI9hulzPrq7IAZ8CPBUKHnf11Xe uo0ha0eGTeJJar3cJpCBKGAPDqtr4zQ9bXVKYnyiZvChmpgr3w4cR42yG71PqEDlmXKZ bVg6mXCGFFbJV4lFFaSrd4kbFiXl4lucfCV06jTMw7TSDaFtSjcGm+RrnURQvNuGvl/4 Zvlf09zTssnwwuYT1Jr5aCpOBszj/aLSkAxSPpdQ9I28hdbArfqHBsUAnESIFVftaGd3 EJDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:cc:from:references:to :subject; bh=XmI/TPEKmETdFx1andshzUpktzB7TcKQOxSLguH1K4Y=; b=zhBCbFM+oBzErLCJTKO0Z5aPLStW7Un4iMF5LjCUpUb4fOJyexoWKOXqqKU6Ia6GHG T3LLK12u0hKmwX6WRJb1ZfD/H5c/J1LIwYmqM/gbBVg19g881za84lc7huC+KNb7OrEv Dvy5lwq0YGSWdg5Pd9C/PGfWEldrhiW7uVraKW0nrbbUba3HbJAIydcY9s0KgpozGKSk jjyuRiIG5bW0HMQOQlox5oGPYzzRZ+dRqteACRMNpdymQM2OUZVjG4+A1OURKHguu/H0 sPReCk5SJDB6cU2P98TG3lmfG/9yzBr2hL9A2kF7Y3nriMllb7ZyokEs2p630H/RUHKb /yxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p4si12229225ejr.271.2021.05.31.01.31.34; Mon, 31 May 2021 01:31:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230410AbhEaIa4 (ORCPT + 99 others); Mon, 31 May 2021 04:30:56 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:3478 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230315AbhEaIaj (ORCPT ); Mon, 31 May 2021 04:30:39 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4FtpKM4Ft1zYq8h; Mon, 31 May 2021 16:26:15 +0800 (CST) Received: from dggpemm500014.china.huawei.com (7.185.36.153) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 31 May 2021 16:28:58 +0800 Received: from [10.174.179.184] (10.174.179.184) by dggpemm500014.china.huawei.com (7.185.36.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 31 May 2021 16:28:58 +0800 Subject: Re: [PATCH V2 00/12] e2fsprogs: some bugfixs and some code cleanups To: References: From: Wu Guanghao CC: , =?UTF-8?B?0JHQu9Cw0LPQvtC00LDRgNC10L3QutC+INCQ0YDRgtGR0Lw=?= , , Message-ID: <57045838-ae1a-d1d9-23ef-8977a4accc17@huawei.com> Date: Mon, 31 May 2021 16:28:19 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.184] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500014.china.huawei.com (7.185.36.153) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Hello Ted, Thank you for your advice, I will pay attention to it in the future. Do I need to resend the series of patches or continue to send the remaining patches this time? Thanks, Wu Guanghao On Mon, 31 May 2021 00:28:46 -0400, Theodore Ts'o wrote: > > > > On Mon, May 31, 2021 at 09:23:49AM +0800, Wu Guanghao wrote: >> V1 -> V2: >> >> [PATCH V2 03/12] zap_sector: fix memory leak >>     free and return operators placed in {} block >> >> [PATCH V2 04/12] ss_add_info_dir: fix memory leak and check whether,NULL pointer >>     modified "=" to "==" >> >> [PATCH V2 06/12] append_pathname: check the value returned by realloc to avoid segfault >> [PATCH V2 07/12] argv_parse: check return value of malloc in argv_parse() >>     Fix typos >> >> [PATCH V2 10/12] hashmap: change return value type of, ext2fs_hashmap_add() >>     remove "new_block = NULL;" > > Did you only send the patches that you changed, and didn't resend the > patches that didn't change between V1 and V2? > > It's actually better if you resend the whole series in the future. > > Thanks, > >                     - Ted > . > .