Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1036793pxj; Wed, 2 Jun 2021 19:00:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTh+Su+AnecO4/INBEAcDHE5xxinL/G+CpvKg8uT1RIIrGGNF/YLIt4P6XDOiW9MGr6NmQ X-Received: by 2002:a17:907:9691:: with SMTP id hd17mr36490439ejc.67.1622685604235; Wed, 02 Jun 2021 19:00:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622685604; cv=none; d=google.com; s=arc-20160816; b=E9dGJQAUVepUAOJ8t8lkyGop0PgFhFb2fljZrj6J3hb/cztqmXKLeKyChFEqBmAbvc 5dndOLQlezwro1RPqpnFAOAl5wBw9qZTRBYaRS8ntYlau7XI1I2i0EMtekh9kxKnH10S ISljQyB8CcGjz47/jvo50jxYbH4lNkTkMvVJhqufQfAsuA0HByCUX+IeYKgzH63VGA7u e1g4cuLMeF/kbyn5D2YM55gN3mbf70O1aSVTvOdeD5p7Kr5lS8QQ28FTfex6bTJcaK7b kNN392GILgSyaVg9MGzNGE+mRr+qYnBYDGV96PSiHRiSqjoYQmJbWRr0ZUDU+zLzgDhs Z42A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=fHQ1XFDp2Wt8EjIt9ZCtWzAWDI1+Juw5G/DTshMjDyQ=; b=tuWs9MEu9+3s7+a0xLTK9KoBmAmQtCzspRtsju3UGcnJM5fEZfzbOSLFXxgN0z+dUd u2i9ezWhvwfW1ih3inzfe7UX2+KXdAgkjQCaYSCz5hQo/VapPzJPa3CLbFE1v4xthfBF N60j4yojF3caQhRRv3DejuP3Bk/iDNMDhjxEGS9Y7Nm57ujIKi2AFzsoFsMpxASsJxxI cu5vmC7gKUKWqWZNdgHpkYhJzz9PGJOhdiBTy5h5C6A/ScZS/5Bp36pKG2j25JQCfi/K bj8BQP+oPNYgpTCzK67OywnCA1eyUT050/raZtWbZaOZz8m50hWzaHtLM0s69oHcnSK8 H6Rg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g10si1181003edu.100.2021.06.02.18.59.35; Wed, 02 Jun 2021 19:00:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229567AbhFCCBF (ORCPT + 99 others); Wed, 2 Jun 2021 22:01:05 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:44638 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229541AbhFCCBF (ORCPT ); Wed, 2 Jun 2021 22:01:05 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 1531xJ3p015418 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 2 Jun 2021 21:59:19 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 2322815C3CAF; Wed, 2 Jun 2021 21:59:19 -0400 (EDT) Date: Wed, 2 Jun 2021 21:59:19 -0400 From: "Theodore Ts'o" To: Harshad Shirwadkar Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH] ext4: fix fast commit alignment issues Message-ID: References: <20210519215920.2037527-1-harshads@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210519215920.2037527-1-harshads@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, May 19, 2021 at 02:59:20PM -0700, Harshad Shirwadkar wrote: > From: Harshad Shirwadkar > > Fast commit recovery data on disk may not be aligned. So, when the > recovery code reads it, this patch makes sure that fast commit info > found on-disk is first memcpy-ed into an aligned variable before > accessing it. As a consequence of it, we also remove some macros that > could resulted in unaligned accesses. > > Signed-off-by: Harshad Shirwadkar Applied, thanks. - Ted