Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 9 Jun 2021 10:56:30 +0200
From:   Jan Kara <jack@suse.cz>
To:     yangerkun <yangerkun@huawei.com>
Cc:     tytso@mit.edu, jack@suse.com, harshadshirwadkar@gmail.com,
        linux-ext4@vger.kernel.org, yukuai3@huawei.com
Subject: Re: [PATCH] jbd2: clean up misleading comments for
 jbd2_fc_release_bufs
Message-ID: <20210609085630.GJ5562@quack2.suse.cz>
References: <20210608141236.459441-1-yangerkun@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210608141236.459441-1-yangerkun@huawei.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Tue 08-06-21 22:12:36, yangerkun wrote:
> This comments was for jbd2_fc_wait_bufs, not for jbd2_fc_release_bufs.
> Remove this misleading comments.
> 
> Signed-off-by: yangerkun <yangerkun@huawei.com>

Good point! Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/jbd2/journal.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index 2dc944442802..ea46e5ad6b59 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -934,10 +934,6 @@ int jbd2_fc_wait_bufs(journal_t *journal, int num_blks)
>  }
>  EXPORT_SYMBOL(jbd2_fc_wait_bufs);
>  
> -/*
> - * Wait on fast commit buffers that were allocated by jbd2_fc_get_buf
> - * for completion.
> - */
>  int jbd2_fc_release_bufs(journal_t *journal)
>  {
>  	struct buffer_head *bh;
> @@ -945,10 +941,6 @@ int jbd2_fc_release_bufs(journal_t *journal)
>  
>  	j_fc_off = journal->j_fc_off;
>  
> -	/*
> -	 * Wait in reverse order to minimize chances of us being woken up before
> -	 * all IOs have completed
> -	 */
>  	for (i = j_fc_off - 1; i >= 0; i--) {
>  		bh = journal->j_fc_wbuf[i];
>  		if (!bh)
> -- 
> 2.31.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR