Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp484378pxj; Thu, 10 Jun 2021 05:44:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwuoWpJHUTo3pT8el2/xhHAUKGcr/FK9Z5BXBv4ulDhLbnQZN6Eav5XGn2YbdqErLeVZOll X-Received: by 2002:a17:906:2c54:: with SMTP id f20mr4309253ejh.91.1623329098711; Thu, 10 Jun 2021 05:44:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623329098; cv=none; d=google.com; s=arc-20160816; b=v07AYkZZDo5uaI9SQh/xqYJQc9xMd3/gsV/BsSzZnT0LmSoTm6QQzlO8G/5aawLomY YeOIkEZ+9+hj0Vz3IdEuX/nBP3zJFmWMdM3WLPozfvQ6JTklddun0Y90ClkjhXiQZJnb digjAiSC0wejuO8x9hIcSJEcBvYQ3XRfmgjKstCaawMw0yoS6A6YTclpNTdwNY3I8UCm WKXntctTfSVmIPNZDtNb/GD5RohfGhSYZkRH+qojwLf+v6Wy3BPdlO3Vk7YxFT3BTY30 6AV8hMUHdT2uGhXN3II8IVeIAa22AGUBlwQ5BM00Rlcq5oj7Bw9lvLs082E3jQWg2Eoz Ykig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=ERGvPKyejnfegUXiUI5TBALLR98HuWU+7/Q+tACPbYI=; b=PwI9v8teeo8m9UAfoIoVZDggLB2o/jhpQ/ebkc8NpK3J2v8r4eGlsovrUNFFBkygbr irnbHIn7Fin1qTxrpOxfM2jntirEUZ+sdiBhM1oTHaE3QkaXPakj0RNuI2ZBdAnbyrpv r4w1x1NcTSmW699YIPN6KxERtx0wO25hC3mY3iif/pjirIuIDMH70Z9nfhVp58Z9EIbl KCGGdBXjGeASpyc9ac1Nwe4iCil7Nj5apOkAKGoK845s658I42Orw7oAK0sEER2r0gZm QNR5FziIJ0SLuqTPp3nr2QJodNCM8yd9cMQHXsIwhAl0CSKN1qCxRbRMchSwA0vOPFYf ftXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=bWmonaOQ; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p8si2159636ejc.107.2021.06.10.05.44.30; Thu, 10 Jun 2021 05:44:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=bWmonaOQ; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230084AbhFJMp2 (ORCPT + 99 others); Thu, 10 Jun 2021 08:45:28 -0400 Received: from mail-ua1-f48.google.com ([209.85.222.48]:44738 "EHLO mail-ua1-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230001AbhFJMp1 (ORCPT ); Thu, 10 Jun 2021 08:45:27 -0400 Received: by mail-ua1-f48.google.com with SMTP id 68so1214033uao.11 for ; Thu, 10 Jun 2021 05:43:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ERGvPKyejnfegUXiUI5TBALLR98HuWU+7/Q+tACPbYI=; b=bWmonaOQtQnoMrqggNjQmbBLp/OFsefkhaXRpT3N30oDxasxyxX5+zHqOhyxg8TwQ1 9WhDWldZuNugQzNq9CRVa79/7odXcgVZfZJpa4jozV3UwwVJh+rViZAq1j+cqvO83+lk Ul0lp34cK0STCoHisDcJwkiJqPEl1W1Jca9Ac= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ERGvPKyejnfegUXiUI5TBALLR98HuWU+7/Q+tACPbYI=; b=FXQtSW60oY+rMeq9xu8X5X8hJxT7GkUENJybYYOZqjjCxeNA4/5DrXL+uNgtozM9Ae ITnujoqgjIxxsGRakSVIdDB63Gu+tFiysUpbKUPrpp8/vO+jkPClC9yQHzBUXAJi800d LoPcvm3/ckwfovtVQyWRaaJzebJviTYAsUVqFjF/OW5tNUy8x+zE4t9iOubcp+rtIFNu iVPkyuluqrKdkzugC5lqrcCQ/Cw8OgXUnbVW9BJLigwR9TlK4YoI9m7b/SzmEl53oXnc YPsWn2RRmhTxt8c4IAje2mN5IqCQukiWuVcSrl4rTCh0WCJjr5XvhhamRSs/DN4FDCv0 fYYQ== X-Gm-Message-State: AOAM532m4zF4A53HrpJhH7thNwf0A7c/B0N8yxLc8u0oa0QsvEZKjgvz yKsFZtE119VLUNZH23ls0cfNNSCfPQcCX2B/XxGCfKXTOLngCQ== X-Received: by 2002:ab0:2690:: with SMTP id t16mr4105093uao.9.1623328942641; Thu, 10 Jun 2021 05:42:22 -0700 (PDT) MIME-Version: 1.0 References: <20210607144631.8717-1-jack@suse.cz> <20210607145236.31852-12-jack@suse.cz> In-Reply-To: <20210607145236.31852-12-jack@suse.cz> From: Miklos Szeredi Date: Thu, 10 Jun 2021 14:42:12 +0200 Message-ID: Subject: Re: [PATCH 12/14] fuse: Convert to using invalidate_lock To: Jan Kara Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig , Dave Chinner , ceph-devel@vger.kernel.org, Chao Yu , Damien Le Moal , "Darrick J. Wong" , Jaegeuk Kim , Jeff Layton , Johannes Thumshirn , CIFS , Ext4 , linux-f2fs-devel@lists.sourceforge.net, linux-mm , linux-xfs , Steve French , Ted Tso , Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, 7 Jun 2021 at 16:52, Jan Kara wrote: > > Use invalidate_lock instead of fuse's private i_mmap_sem. The intended > purpose is exactly the same. By this conversion we fix a long standing > race between hole punching and read(2) / readahead(2) paths that can > lead to stale page cache contents. > > CC: Miklos Szeredi > Signed-off-by: Jan Kara Reviewed-by: Miklos Szeredi Thanks, Miklos