Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp98542pxj; Tue, 15 Jun 2021 21:10:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx77H+65ClpFDGKI8EAJpL4dNa0oXTkSLp/Z/z4yJt5IVkuhXfqMPEyp8p5OHrsDgWiH8VZ X-Received: by 2002:aa7:cdc5:: with SMTP id h5mr1628095edw.217.1623816615203; Tue, 15 Jun 2021 21:10:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623816615; cv=none; d=google.com; s=arc-20160816; b=tZ7kTVjxqEBVhX1VFGSVPwqoX0eev0HEsf7WWyVV2V72XRN21tYuYTvA3zag+KVVOs IvRkcbF0EwHXtnYmqBwzKQMKDQNmbRPn5KFKwgT7g3og+ogdaLrDuYWo3pU2ySt9jNVT jFWGo5/GrM/pN4FCy36kIcT/wOWvHGECOyt6lRVAKE643fzEF3nGZeDG9haT24T4UhiE IySk5Th8ssJdZBgMqFI7kJJ26COW+PVeMK/6reNS/5YpEIu0IbsSq5S6rUPllz0GfqpB pg/qUOCxxCvWOIdqZcMH82IwTP2t18zENf1akv8Q86KZwzPUyt2e1vkNUgjw2IbsZcH+ ZH3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=+hJYay8JR5Szrm3esdkGPPnSrjDyFQjXCxZ0d9ypRKM=; b=WWwPUq1+LTuqmmc1AgjTG9Cd+zZjaO5A1YnXveGvC1NeQddg+sZgFik3MH7BQ1+sY+ vIyv55gkj/IkRsIsdMOPo6EUUN5ZKmU3JUSGFdfuKyc1yZnVVe8oemYtyyrpwPMBzsBJ 8wX7xyZhEmMolReNzoUL5bPcYsKGifnPpEHXLHzabXVVAHmWkmApcYEdZmm7f/tP8jYu W3BX/SEJyZsCt9Vg6NuuJUBwOKyMP5ijPpcy4kuZBKiL7XBsh06y3p8SPrBTCS+d3M7+ x+Ebvr74igUylETspwZ0pR6cz243SeTeMFis5wyXCgaZqVGj5GMftOwgPZHF6MU74Wg+ RMNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=n0s17+Qb; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x15si862724edd.555.2021.06.15.21.09.41; Tue, 15 Jun 2021 21:10:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=n0s17+Qb; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229503AbhFPELo (ORCPT + 99 others); Wed, 16 Jun 2021 00:11:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbhFPELo (ORCPT ); Wed, 16 Jun 2021 00:11:44 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0C85C061574; Tue, 15 Jun 2021 21:09:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+hJYay8JR5Szrm3esdkGPPnSrjDyFQjXCxZ0d9ypRKM=; b=n0s17+QbCeywB7tT55kKef7453 IRB44+PDdtgICy2G0YMcftFVm199pSyAdpJGLKekmgdDBZ6XuffMxQMX36hOLOXe28uAJsKKfDKko FgkgOoBPpT+eEqyG+epXsLvvuUqfdJL6RVTgTnRfMA2AIuN7I3jFsrqBQ2x/0gbyZD/CPxj1eKJxL ElbswIIRhKlBbbiBiG7O14d0EA2iO3poptdiTrI+Td/PVfTWXo8LEs20orcm9ZuI+/Fcdk16HSbDc KC3M91MxPVUHrVsFUE3HxZt9AdJ5Oad68ELIZPI7ZVTOuGQ1zl3x3qOXLlmEGjVVvc2qeqW5fFSBn II4beYog==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltMrV-007ZmS-MR; Wed, 16 Jun 2021 04:09:11 +0000 Date: Wed, 16 Jun 2021 05:09:09 +0100 From: Christoph Hellwig To: Gabriel Krisman Bertazi Cc: Shreeya Patel , Christoph Hellwig , Theodore Ts'o , adilger.kernel@dilger.ca, jaegeuk@kernel.org, chao@kernel.org, ebiggers@google.com, drosen@google.com, ebiggers@kernel.org, yuchao0@huawei.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH v8 4/4] fs: unicode: Add utf8 module and a unicode layer Message-ID: References: <20210427062907.GA1564326@infradead.org> <61d85255-d23e-7016-7fb5-7ab0a6b4b39f@collabora.com> <87bl9z937q.fsf@collabora.com> <87mtti6xtf.fsf@collabora.com> <7caab939-2800-0cc2-7b65-345af3fce73d@collabora.com> <687283ac-77b9-9e9e-dac2-faaf928eb383@collabora.com> <87zgw7izf8.fsf@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zgw7izf8.fsf@collabora.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jun 02, 2021 at 08:07:07PM -0400, Gabriel Krisman Bertazi wrote: > I wasn't going to really oppose it from being a firmware but this > detail, if required, makes the whole firmware idea more awkward. If the > whole reason to make it a firmware is to avoid the module boilerplate, > this is just different boilerplate. Once again, I don't know about > precedent of kernel data as a module, and there is the problem with > Makefile rules to install this stuff, that I mentioned. > > We know we can get rid of the static call stuff already, since we likely > won't support more encodings anyway, so that would simplify a lot the > module specific code. Well, another thing we can do is a data-only module. That is a module that just contains the tables, with the core code doing a symbol_get on them.