Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp148256pxj; Tue, 15 Jun 2021 22:32:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYTrK+gln15woAVv26TiH+knggjsN+6X+ArV9oGUvPwwyAcVmiTA1JldDyuvFosTOU9e1X X-Received: by 2002:a05:6e02:12c4:: with SMTP id i4mr2342794ilm.141.1623821534726; Tue, 15 Jun 2021 22:32:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623821534; cv=none; d=google.com; s=arc-20160816; b=h+gsiMm8+/k2mdyojsBB2TIifLlLF930mqsROaUz79auSDaueN86tT15p8Fn/Xs+qQ SifoD4YfrN+uRGP+4Z6N4R8gJ7RYYJiKRoW7wcGJfSrV/WzBK+ANdMsgkf4oRrnz+3Jr hFiCQL/Xpg1f8IFhJcWRJzcAfDJGUcXBPnSZ4sZOtq59carM4LRsWvGIs3DwEwLPivft N9dfEyids3SlPfO7BvrUY+khN008K2ThQjA3rygLGHhhGLDqxepi41HSukJg2gRAQms8 ep/VySK0Kb153zGP3P8fHO7FtEzeja717qp5Zaw11/wuqgdVoJp8/yVV/zGUJTMk+KAO MJBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=t++zkK6+3jhlyv3CdaWkO1s/YSSZiDhwUfUI7hox61M=; b=I6q/ciSKnyWebvqHoBCItkxd422YlHqajVHnbdteGx1mChPgL6rpkrFXS4MaUICsA8 d6PF0eWoTV3HYxhYb/CzANrQGx+FuC4bbp1V8LFI71Nf5/L+IGiBAeTpM6jUgo2/cAGr au3t8UHQP7P6bt9YCixRWbnH4N/PyZsEvz24NYQ2M+g/SrZy8gLdSsYJvgKQj5Mj50ES XMLrFU8SXQCAnfMmeqDCbG+MeI2sZ1BIe6MQYnaLYNkjlW4uqRQjfUUjpVryqulC9Mpr 7W6SWmnLQpRPz2oiwK6idrBOWP6af5WV5AaKloinctUnO1IJdm3kqNMOBUmnFycr3SJA 1cGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=L51zmJv2; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p10si1243704ilg.70.2021.06.15.22.31.35; Tue, 15 Jun 2021 22:32:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=L51zmJv2; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230503AbhFPFdb (ORCPT + 99 others); Wed, 16 Jun 2021 01:33:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229476AbhFPFdb (ORCPT ); Wed, 16 Jun 2021 01:33:31 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 521B2C061574; Tue, 15 Jun 2021 22:31:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=t++zkK6+3jhlyv3CdaWkO1s/YSSZiDhwUfUI7hox61M=; b=L51zmJv2LnWVezREZ5qO4Sb4wj hCkTE/m0QqQeN/5fgrUDw/vgFNIIeg8Tim3ewCdoojjCilGOiOR8c57029dd+orJh4t/rmvG+zR/a UHO8a7GTTdjaSw/kYKR/waNT0IQxcbOBjD41L++7qEygfR8I4on7v/P+EaeWtR63wtcqY1TO2xSjQ 9P8FymJ5aMKYu9uPSQ7YvWMS45J/3ptspKhWI6C9d9j4lZ0Xa63qEj+Ap3dUQFJO2ltsaz2mqEU3D iiFAOfRtA97vNbBHFBSJkoX95S7mAUqFyCzG8TXG+C1sA44zQbHJcvdjyoMdBgCBcGaMbTYHXu6FM EEVq3gEA==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltO8n-007dWP-Eq; Wed, 16 Jun 2021 05:31:07 +0000 Date: Wed, 16 Jun 2021 06:31:05 +0100 From: Christoph Hellwig To: Jan Kara Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig , Dave Chinner , ceph-devel@vger.kernel.org, Chao Yu , Damien Le Moal , "Darrick J. Wong" , Jaegeuk Kim , Jeff Layton , Johannes Thumshirn , linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-xfs@vger.kernel.org, Miklos Szeredi , Steve French , Ted Tso , Matthew Wilcox , "Darrick J . Wong" Subject: Re: [PATCH 02/14] documentation: Sync file_operations members with reality Message-ID: References: <20210615090844.6045-1-jack@suse.cz> <20210615091814.28626-2-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210615091814.28626-2-jack@suse.cz> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Jun 15, 2021 at 11:17:52AM +0200, Jan Kara wrote: > Sync listing of struct file_operations members with the real one in > fs.h. Looks fine: Reviewed-by: Christoph Hellwig But I wonder if we could just move the locking documentation into the header itself using kerneldoc annotation to avoid all this syncing..