Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp37752pxj; Wed, 16 Jun 2021 19:37:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyIb9BB/W0CdoC+C+tEAaMlBST6hyVRlwhGd18Dju6cdzdYe6FyB6fvnTtbmwm8LZvT/L6p X-Received: by 2002:aa7:c619:: with SMTP id h25mr3386146edq.388.1623897441977; Wed, 16 Jun 2021 19:37:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623897441; cv=none; d=google.com; s=arc-20160816; b=A5/tkbb2JENTS7AVLYf0ML3BGq33CZ175RKqsj4S+IKRnjr0FuSWe6WOZ2XgC1QQRo FU2OuIfiaavpM04qC1gzItlL+/na9ynxcoepLyP7qk9gL2Nti3RzLuUvKmMNJY9LFmCY y9Y0qIhkH0OytaY3LoXnKlPV7ZgDDPZyUQ/oAGItO5wPW2EZ69fg/GYxdPuyaNGKM7WE AvuZ3d/AodYFJVHJ5BZlxmq0CrkreTugg1mJ5YHtu1ULvXOOyKyflW4/+v2D1sNMY/ci TF6AzBNEDxBn7iDAj7glqG5atExuucKXmZU/hGt3Ub06qu/yJvcvC6jc7QVvXCX4TeW2 X/Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=EkBtwK5ef5mf+NUCVFzGYo0b74cYnh0vor7BnCEcJAo=; b=0VKQy1ZvHlUuwDMgB68w852p2QWrKyrwmFi5amn6OTXXhsIryiKKXxgy5PbzD1ow0m VCcY7tnw/BaNAO1TAT9PWcsKixFJwEwk14ZvKzPl73/rvsNdiIlspWAkrgn0t6ztEmIO 7sjI8h+0KFvocF9qiJ57yEJPCmtA105zwf0627n+jmgCDTtzPGdP9FqB8SjwaM1fs2A7 KSxNPNNrY9qNSQ7hX9h4fMd+u6wgm5cKZBVHMqVScI2wlhqRkWPu80BHW0JB/yS9pk5t kEYomH9DdQuXkm1TFBtilBVeIkuSOcpY9E5aMp/ulWWIzfonqcn2SUpTzqnl3cgMU82F fOUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q12si3865395edr.5.2021.06.16.19.36.58; Wed, 16 Jun 2021 19:37:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234560AbhFPX3A (ORCPT + 99 others); Wed, 16 Jun 2021 19:29:00 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:60497 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S234508AbhFPX27 (ORCPT ); Wed, 16 Jun 2021 19:28:59 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 15GNQhK6031425 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 16 Jun 2021 19:26:43 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id E0A7815C3CB8; Wed, 16 Jun 2021 19:26:42 -0400 (EDT) Date: Wed, 16 Jun 2021 19:26:42 -0400 From: "Theodore Ts'o" To: Joseph Qi Cc: adilger.kernel@dilger.ca, riteshh@linux.ibm.com, linux-ext4@vger.kernel.org Subject: Re: [PATCH v2] ext4: remove redundant check buffer_uptodate() Message-ID: References: <1619418587-5580-1-git-send-email-joseph.qi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1619418587-5580-1-git-send-email-joseph.qi@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Apr 26, 2021 at 02:29:47PM +0800, Joseph Qi wrote: > Now set_buffer_uptodate() will test first and then set, so we don't have > to check buffer_uptodate() first, remove it to simplify code. > > Reviewed-by: Ritesh Harjani > Signed-off-by: Joseph Qi Part of this change was already submitted by Yang Guo from Huawei; I've applied the portion of this patch which is still applicable (which was for ext4_buffer_uptodate function) Thanks, - Ted